diff --git a/Documentation/RelNotes/2.55.0.adoc b/Documentation/RelNotes/2.55.0.adoc index 8543cad65e491f..f5643534dcc19c 100644 --- a/Documentation/RelNotes/2.55.0.adoc +++ b/Documentation/RelNotes/2.55.0.adoc @@ -31,7 +31,9 @@ UI, Workflows & Features subcommand "git url-parse". * Misspelt proxy URL (e.g., httt://...) did not trigger any warning - or failure, which has been corrected. + or failure, which has been corrected. We had a regression in this + update that broke https:// proxies, but that has been caught and + corrected. * Document the fact that .git/info/exclude is shared across worktrees linked to the same repository. diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN index 04b0a8c70f259a..6e4df991932910 100755 --- a/GIT-VERSION-GEN +++ b/GIT-VERSION-GEN @@ -1,6 +1,6 @@ #!/bin/sh -DEF_VER=v2.55.0-rc2 +DEF_VER=v2.55.0 LF=' ' diff --git a/http.c b/http.c index 5f0f42fb185d25..b4e7b8d00b3cdc 100644 --- a/http.c +++ b/http.c @@ -819,6 +819,8 @@ static int set_curl_proxy_type(CURL *result, const char *protocol) if (has_proxy_cert_password()) curl_easy_setopt(result, CURLOPT_PROXY_KEYPASSWD, proxy_cert_auth.password); + + return 0; } return -1; diff --git a/t/lib-httpd/apache.conf b/t/lib-httpd/apache.conf index 40a690b0bb7c9b..4149fc1078a877 100644 --- a/t/lib-httpd/apache.conf +++ b/t/lib-httpd/apache.conf @@ -4,6 +4,7 @@ DocumentRoot www LogFormat "%h %l %u %t \"%r\" %>s %b" common CustomLog access.log common ErrorLog error.log +Timeout 600 LoadModule log_config_module modules/mod_log_config.so diff --git a/t/t5551-http-fetch-smart.sh b/t/t5551-http-fetch-smart.sh index e236e526f0defb..dcff0bc7d46421 100755 --- a/t/t5551-http-fetch-smart.sh +++ b/t/t5551-http-fetch-smart.sh @@ -397,15 +397,16 @@ create_tags () { } test_expect_success 'create 2,000 tags in the repo' ' + git init --bare "$HTTPD_DOCUMENT_ROOT_PATH/many-tags.git" && ( - cd "$HTTPD_DOCUMENT_ROOT_PATH/repo.git" && + cd "$HTTPD_DOCUMENT_ROOT_PATH/many-tags.git" && create_tags 1 2000 ) ' test_expect_success CMDLINE_LIMIT \ 'clone the 2,000 tag repo to check OS command line overflow' ' - run_with_limited_cmdline git clone $HTTPD_URL/smart/repo.git too-many-refs && + run_with_limited_cmdline git clone $HTTPD_URL/smart/many-tags.git too-many-refs && ( cd too-many-refs && git for-each-ref refs/tags >actual && @@ -483,12 +484,12 @@ test_expect_success 'test allowanysha1inwant with unreachable' ' test_expect_success EXPENSIVE 'http can handle enormous ref negotiation' ' test_when_finished "rm -f tags" && ( - cd "$HTTPD_DOCUMENT_ROOT_PATH/repo.git" && + cd "$HTTPD_DOCUMENT_ROOT_PATH/many-tags.git" && create_tags 2001 50000 ) && git -C too-many-refs fetch -q --tags && ( - cd "$HTTPD_DOCUMENT_ROOT_PATH/repo.git" && + cd "$HTTPD_DOCUMENT_ROOT_PATH/many-tags.git" && create_tags 50001 100000 ) && git -C too-many-refs fetch -q --tags &&