Bump Meziantou.Analyzer from 3.0.98 to 3.0.114#181
Conversation
--- updated-dependencies: - dependency-name: Meziantou.Analyzer dependency-version: 3.0.113 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (2)
🧰 Additional context used📓 Path-based instructions (3)*📄 CodeRabbit inference engine (.editorconfig)
Files:
**⚙️ CodeRabbit configuration file
Files:
**/*.props⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (1)
Summary by CodeRabbit
Walkthrough
Analyzer Version Bump
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (7 passed)
Comment |
…u 3.0.114 bump (#182) Meziantou.Analyzer 3.0.98 -> 3.0.114 (#181) newly enforces MA0074 on the five `string.Contains(string)` call sites in ErrorOrX.Generators, which under TreatWarningsAsErrors broke `main` (AOT Publish Smoke, run 28442562600). The netstandard2.0 BCL lacks `Contains(string, StringComparison)`; the ANcpLua.Roslyn.Utilities.Sources polyfill supplies it (that overload's existence is precisely what made MA0074 start firing). Rather than the BCL overload, switch to the package's `ContainsOrdinal` helper — the same ordinal-explicit idiom already used alongside (`StartsWithOrdinal`, `EndsWithOrdinal`). Behavior is identical (default string.Contains is already ordinal); the rule is satisfied by construction. Verified: `dotnet build -c Release` of the generator project and full slnx both 0 warnings / 0 errors; 156 generator tests pass. Co-authored-by: ANcpLua <alex_nachtmann@yahoo.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
updated-dependencies: