feat: complete uk companies house handler v2a (#220)#255
Conversation
|
Hey @Areen-09, thanks for this, looks clean and good as always! A few small things before merge:
After this merges, you can tackle v2b (pipeline) and v2f (agent playbook) in follow-up PRs or a signle PR, up to you. Nice work keeping it focused. Merge once those small fixes are in <3 |
|
Thanks so much for the detailed review @rosspeili ! <3 I've addressed all the requested changes:
Once this PR is merged, I'll start working on the next phases (v2b pipeline and then v2f agent playbook). Thanks again for the review! |
…text carry-forward, partial envelopes, and interactive examples (ARPAHLS#220)
e9ab12d to
46b1c58
Compare
|
Hi @rosspeili ! Just a quick update, this PR had a merge conflict after some newer changes were merged into Whenever you have a chance, I'd really appreciate another look. Thanks! |
|
Thanks @Areen-09, this looks great and addresses everything from the review. Small nits, non-blocking, but consider for next PR:
Still, happy to merge this once CI is green. 🙏 |
Description
Completes Phase v2a of the UK Companies House skill upgrade.
contextschema to carry forwardcompany_number,company_name,last_action,officer_filter, andselected_transaction_idbetween steps without forcing the LLM to repeatedly extract and pass them._get_officerssafely falls back oncompany_namevia context to save API calls.partialenvelope status andpipelineparameter schema in preparation for the upcoming Phase v2b orchestration.gemini_uk_companies_house_handler.pyto be a fully interactive chat loop, and updateduk_companies_house_handler_common.pyto natively demonstrate context passing across actions.Type of Change
skills/skills/skillware/core/loader, env, adaptersskillware/cli.py,docs/usage/cli.mdexamples/*.py, agent loops,examples/README.mdpyproject.toml,MANIFEST.inChecklist (all PRs)
Fixes #…orRefs #…)python -m black --check .andflake8pass locally (or CI-equivalent subset)pytest skills/andpytest tests/pass locally when relevantCHANGELOG.mdupdated under[Unreleased]when user-visible behavior changesexamples/README.mdupdated if this PR adds, renames, or removes a runnable scriptpytest tests/test_registry_docs.pywhen skills, examples index, or agent-loops matrix changedNew or updated skill
Skip unless this PR adds or changes files under
skills/.Bundle and metadata
skills/<category>/<skill_name>/(fromtemplates/python_skill/or equivalent)manifest.yaml:name(full ID),version,description,parameters,constitution, realissuershort_description,issuer.github,issuer.org,requirements,env_varsLogic, cognition, tests
skill.py(no ad-hoc LLM-generated execution paths)instructions.mdexplains when and how to use the skillcard.jsonissuer matches manifest when presenttest_skill.pycovers execution and schema expectationsSkillLoader.load_skill("<category>/<skill_name>")succeeds (or deps documented)Documentation and catalog
docs/skills/<skill_name>.mdand row indocs/skills/README.mdConstitution and safety (skills only)
No safety or constitution changes. The skill remains strictly read-only for public company data.
Related Issues
Completes #220 v2a