Fix(reader): toggle controls from the whole reader surface, not per-item#76
Merged
Conversation
Tap-to-toggle was a per-item clickable applied inside the text's horizontal margin padding, so the side margins, inter-paragraph gaps, empty space below short chapters, and gaps around image groups were dead zones where a tap did nothing. Felt like taps "not registering", worst when dismissing the menu. Add a single full-screen detectTapGestures on the content container. The LazyColumn/pager still win drags (the detector cancels on any consumed movement); per-item clickables still consume taps over text and images, so the container only fires in the former dead zones. Each tap toggles exactly once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tap-to-toggle for the in-reader menu was a per-item
clickable, and on text it sat inside the horizontal margin padding. That left dead zones where a tap did nothing:Arrangement.spacedBy(fontSize × paragraphSpacing))Taps landing there silently no-op, which reads as "the tap did not register" — most noticeable when dismissing the menu.
Change
Single full-screen
detectTapGestureson the content container inReaderContentArea.kt. It cancels on any consumed movement, so theLazyColumn/pager keep scroll/swipe drags; the per-itemclickables still consume taps over text and images, so the container only fires in the former dead zones. Each tap toggles exactly once.Verification
compileStandardDebugKotlin+detekt: pass.