ogar-vocab: classview() accessor + D-CLASSID-HI-U16-SPELLING homonym …#183
Merged
Merged
Conversation
…note on APP_PREFIX The lo-u16 render-skin slot is the 'classview' in the operator's domain:appid:classview (2:2:4 nibble) spelling — but the const is named APP_PREFIX, exactly the homonym D-CLASSID-HI-U16-SPELLING warns about (the 'appid byte' lives in the HI half = shared concept slot; the per- vendor render skin is the LO u16). A reader (and a recent session) can mistake APP_PREFIX for the appid. Non-breaking clarification: keep APP_PREFIX as the underlying const (every consumer re-exports it) and add a default trait method classview() -> Self::APP_PREFIX as the memorable name that matches the canon layout, plus a doc block on APP_PREFIX naming its position and the homonym. Pin: classview() == APP_PREFIX for all six ports. No value change, no consumer break. 29 ports tests green, clippy clean. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fy8D6Boh4ZBaHSBpadSENN
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_6ba0289e-8878-4158-84e3-86359fcb7e47) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…note on APP_PREFIX
The lo-u16 render-skin slot is the 'classview' in the operator's domain:appid:classview (2:2:4 nibble) spelling — but the const is named APP_PREFIX, exactly the homonym D-CLASSID-HI-U16-SPELLING warns about (the 'appid byte' lives in the HI half = shared concept slot; the per- vendor render skin is the LO u16). A reader (and a recent session) can mistake APP_PREFIX for the appid.
Non-breaking clarification: keep APP_PREFIX as the underlying const (every consumer re-exports it) and add a default trait method classview() -> Self::APP_PREFIX as the memorable name that matches the canon layout, plus a doc block on APP_PREFIX naming its position and the homonym. Pin: classview() == APP_PREFIX for all six ports.
No value change, no consumer break. 29 ports tests green, clippy clean.
Claude-Session: https://claude.ai/code/session_01Fy8D6Boh4ZBaHSBpadSENN