Batch 3D: textord/ccstruct shapes onto V3 SoA facets + OCR arc board entries

[AdaWorldAPI]

Core change

lance-graph-contract/src/textord_facet.rs — Batch 3D of the tesseract-rs OCR arc: the 7 textord data shapes (TBOX, BLOBNBOX, ROW, TO_ROW, BLOCK, TO_BLOCK, POLY_BLOCK) sunk onto facet::FacetCascade per the network-sink precedent (E-OCR-NETWORK-SINK-1):

• classid = compose_classid(<minted 0x0805..0x0807 canon>, <shape ordinal custom-low>) — reuses existing mints (textline/blob/page_layout), no new mints.
• Payload = the 6×8:8 rail carving with a documented field→rail table per shape (i16 box coords full precision; floats rounded / fixed-point with stated loss, e.g. TO_ROW baseline slope ×10000).
• Field inventory comes from the banked ruff walk_tu manifest (239 classes, 14259 triples — no vtable hierarchy, so the sink is field inventory, not a ClassView); header line citations per field (rect.h / blobbox.h / ocrrow.h / ocrblock.h / polyblk.h).
• Intrusive ELIST links + pointers routed to EdgeBlock per doctrine; list content stays content-store.
• 10 new tests (round-trip per shape, classid composition, distinctness); example textord_facet_dump as the future oracle seam. Full crate: 849 lib tests green, fmt + clippy -D warnings clean.

Board (append-only EPIPHANIES entries for the OCR arc landed this branch)

E-OCR-INPUT-LAYER-1 (P2 pixconv+Otsu 3/3+3/3), E-OCR-PAGE-APPROX-1 (P3-alt page E2E + Batch-3A harvests), E-OCR-CONNCOMP-1/E-OCR-TSV-1 (3B 6/6 + P4a), E-OCR-TEXTORD-FACET-1/E-OCR-SCANNED-PDF-1 (3D + D5.2), E-OCR-SEARCHABLE-PDF-1 (D4.5 round-trip; P4+P5 complete; 3E cut).

Companion consumer PR: AdaWorldAPI/tesseract-rs#11.

🤖 Generated with Claude Code

https://claude.ai/code/session_016b33swuXE23hKtqxsHu9p1

---

Generated by Claude Code

Summary by CodeRabbit

• New Features
  • Added OCR layout/facet support for text blocks, lines, pages, and related shape types.
  • Added broader dictionary/graph loading and inspection support, plus new OCR concept entries.
  • Introduced example tools for inspecting graph and layout data from files.
• Documentation
  • Added a GitHub access runbook with practical guidance for clone, push, pull request, and release workflows.
• Chores
  • Updated internal planning notes and status logs for the OCR pipeline rollout.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

[cursor]

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_214e8a05-c97c-472f-888a-996089ae1859)

[coderabbitai]

Warning

Review limit reached

@AdaWorldAPI, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 37 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 39dc3ad7-1b10-4526-9ee3-b18d8656e52b

📥 Commits

Reviewing files that changed from the base of the PR and between e12013f and 5a9d845.

📒 Files selected for processing (3)

• .claude/board/EPIPHANIES.md
• crates/lance-graph-contract/src/dawg.rs
• crates/lance-graph-contract/src/lib.rs

📝 Walkthrough

Walkthrough

This PR adds a new dawg module for parsing Tesseract SquishedDawg binaries with accessors and edge lookup, a new textord_facet module for encoding layout shapes into FacetCascade tiers, five new codebook entries, two example CLIs, a Cargo.toml comment update, and documentation/board/runbook files.

Changes

DAWG and textord facet contracts

Layer / File(s)	Summary
SquishedDawg parsing and accessors crates/lance-graph-contract/src/dawg.rs, crates/lance-graph-contract/src/lib.rs	New module defines NodeRef, DawgType, PermuterType, SquishedDawg with header validation, edge decoding, accessors, edge_char_of lookup, DawgError, and unit tests; wired into crate root.
DAWG dump example crates/lance-graph-contract/examples/dawg_dump.rs	CLI loads a SquishedDawg file and prints header/edge data or exits with an error.
Textord facet shapes and packing crates/lance-graph-contract/src/textord_facet.rs, crates/lance-graph-contract/src/lib.rs	New module defines canon slot constants, BlobShape/TextlineShape/PageShape enums, quantization helpers, and tbox_facet/blobnbox_facet/row_facet/to_row_facet/block_facet/to_block_facet/poly_block_facet constructors with tests; wired into crate root.
Textord facet dump example crates/lance-graph-contract/examples/textord_facet_dump.rs	CLI constructs synthetic facet shapes and hex-dumps each with its classid.
Codebook entries and version fuse crates/lance-graph-contract/src/ogar_codebook.rs, crates/lance-graph-ogar/Cargo.toml	Adds five OCR-domain CODEBOOK entries (textline, blob, page_layout, page_image, ocr_renderer) and updates the ALL count comment from 79 to 84.
Board logs, integration plan, and runbook .claude/board/EPIPHANIES.md, .claude/board/INTEGRATION_PLANS.md, .claude/prompts/github-access-runbook.md	Adds timestamped OCR pipeline milestone log entries, a new integration plan record for pdf-to-text-ocr v1, and a GitHub access runbook documenting proxy/token/PR/release procedures.

Estimated code review effort: 3 (Moderate) | ~30 minutes

Possibly related PRs

• AdaWorldAPI/lance-graph#563: Both PRs extend the OGAR CODEBOOK in ogar_codebook.rs/lib.rs.
• AdaWorldAPI/lance-graph#614: The textord_facet constructors here build on the FacetCascade/FacetTier types introduced by that PR's facet module refactor.

Poem

A dawg of bytes, a facet's tier,
I hopped through bits both far and near,
Edges parsed and boxes packed,
Byte-for-byte, the parity's exact,
Thump-thump — another leaf lands clear! 🐇📦

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly reflects the main change: sinking textord/ccstruct shapes onto V3 SoA facets and adding OCR arc board entries.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 5

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.claude/board/EPIPHANIES.md:
- Line 186: The markdown fence in EPIPHANIES.md is missing a language tag, which
triggers the lint warning. Update that fenced block to use a language identifier
such as text (or the most appropriate language) so the documentation remains
markdownlint-clean. Refer to the bare fence near the epiphany entry and keep the
surrounding content unchanged.
- Line 159: The inline `eeSSSS      ` example in EPIPHANIES.md is triggering the
MD038 whitespace lint because the trailing padding is inside inline code. Move
that sample into a fenced code block or another preformatted example so the
intentional spaces remain visible, and keep the surrounding narrative unchanged.

In @.claude/prompts/github-access-runbook.md:
- Around line 31-125: The GitHub access examples leak the token via argv and
token-in-URL patterns in the clone/push/PR/release flows. Update the runbook
snippets around the direct REST helpers and git commands to use an askpass or
temporary credential-helper approach so the token is never passed as a
command-line argument or embedded in remote URLs. Keep the guidance consistent
across the clone, push, create_pull_request, and release sections, and reference
the existing curl/python/git examples in this document so they can be replaced
in place.

In `@crates/lance-graph-contract/src/dawg.rs`:
- Around line 284-287: In the DAWG deserialization path in read_dawg (the block
that builds edges), preflight the declared edge payload before allocating or
pushing into the Vec. Before the loop over num_edges, validate that the
remaining bytes are enough for num_edges u64 values using the reader position
and total input length, and return an error early if not. This should be done in
the edge-reading logic that uses r.pos(), read_u64(), and the edges buffer so
malformed headers do not cause unnecessary memory growth.

In `@crates/lance-graph-contract/src/textord_facet.rs`:
- Around line 329-349: The facet packing constructors are only using
debug_assert! for enum ordinals, so release builds can still serialize invalid
values and alias them to the wrong bytes. Update the public constructors in
textord_facet.rs, including the facet-packing helpers that build FacetCascade,
to validate region_type, left_tab_type, and right_tab_type with runtime checks
(assert! or Result-based validation) before packing. After validation, pack the
already-checked values directly so invalid ordinals are rejected consistently in
all builds.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 88553495-81fd-4d01-b9c2-9c5235d366f3

📥 Commits

Reviewing files that changed from the base of the PR and between 6bfc719 and e12013f.

📒 Files selected for processing (10)

• .claude/board/EPIPHANIES.md
• .claude/board/INTEGRATION_PLANS.md
• .claude/prompts/github-access-runbook.md
• crates/lance-graph-contract/examples/dawg_dump.rs
• crates/lance-graph-contract/examples/textord_facet_dump.rs
• crates/lance-graph-contract/src/dawg.rs
• crates/lance-graph-contract/src/lib.rs
• crates/lance-graph-contract/src/ogar_codebook.rs
• crates/lance-graph-contract/src/textord_facet.rs
• crates/lance-graph-ogar/Cargo.toml

[coderabbitai]

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Preserve the visible padding in a fenced example.

Line 159's eeSSSS literal is what trips MD038. If the spacing is intentional, move this sample to a fenced block so the whitespace stays explicit without the inline-code lint hit.

🧰 Tools

🪛 markdownlint-cli2 (0.22.1)

[warning] 159-159: Spaces inside code span elements

(MD038, no-space-in-code)

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.claude/board/EPIPHANIES.md at line 159, The inline `eeSSSS      ` example
in EPIPHANIES.md is triggering the MD038 whitespace lint because the trailing
padding is inside inline code. Move that sample into a fenced code block or
another preformatted example so the intentional spaces remain visible, and keep
the surrounding narrative unchanged.

Source: Linters/SAST tools

[coderabbitai]

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Add a language tag to the output fence.

Line 186's fence is bare, which is the markdownlint warning here. Mark it as text (or the appropriate language) so the docs stay lint-clean.

🧰 Tools

🪛 markdownlint-cli2 (0.22.1)

[warning] 186-186: Fenced code blocks should have a language specified

(MD040, fenced-code-language)

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.claude/board/EPIPHANIES.md at line 186, The markdown fence in EPIPHANIES.md
is missing a language tag, which triggers the lint warning. Update that fenced
block to use a language identifier such as text (or the most appropriate
language) so the documentation remains markdownlint-clean. Refer to the bare
fence near the epiphany entry and keep the surrounding content unchanged.

Source: Linters/SAST tools

[coderabbitai]

🔒 Security & Privacy | 🟠 Major | ⚡ Quick win

Don't expose the GitHub token in argv or remote URLs.

Lines 31-125 pass the token on the command line (curl -H ..., python3 - "$GHT") and in git URLs. That can leak via shell history and process listings. Use an askpass or temporary credential-helper flow so the token never appears in argv, and apply it consistently across clone/push/PR/release examples.

🧰 Tools

🪛 LanguageTool

[uncategorized] ~42-~42: The official name of this software platform is spelled with a capital “H”.
Context: ...EN has push (both ruff + OGAR) | | REST api.github.com through proxy | ❌ always block...

(GITHUB)

---

[uncategorized] ~44-~44: The official name of this software platform is spelled with a capital “H”.
Context: ...h/merge-state, releases, checks | | MCP mcp__github__* | PR-create works only where th...

(GITHUB)

---

[uncategorized] ~76-~76: The official name of this software platform is spelled with a capital “H”.
Context: ...quest — create / fix / inspect Try MCP mcp__github__create_pull_request first (works for ...

(GITHUB)

---

[locale-violation] ~97-~97: In American English, ‘afterward’ is the preferred variant. ‘Afterwards’ is more commonly used in British English and other dialects.
Context: ...=30))["html_url"]) PY ``` - Fix a body afterwards: same, method="PATCH", URL `.../pulls...

(AFTERWARDS_US)

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.claude/prompts/github-access-runbook.md around lines 31 - 125, The GitHub
access examples leak the token via argv and token-in-URL patterns in the
clone/push/PR/release flows. Update the runbook snippets around the direct REST
helpers and git commands to use an askpass or temporary credential-helper
approach so the token is never passed as a command-line argument or embedded in
remote URLs. Keep the guidance consistent across the clone, push,
create_pull_request, and release sections, and reference the existing
curl/python/git examples in this document so they can be replaced in place.