cockpit/GeoHelix: sunset + hypsometric terrain shader, auto-scaled relief, wire /garmin/grand-canyon#93
Conversation
…elief; wire /garmin/grand-canyon The map-shader improvements, landing safely in the GeoHelix fork (zero risk to the /helix anatomy body). All verified by real headless-swiftshader screenshots of /garmin/grand-canyon and /garmin/iceland. Shader (uGeo terrain path only; anatomy path kept byte-identical): - HYPSOMETRIC tint — blend the baked KIND colour (water blue / forest green / bare-terrain grey) with the height ramp (revives the dead terrainColor()), so elevation READS as colour: green lowland → brown → grey → white peak. - SUNSET lighting — a low warm key + a cool sky fill replace the old grey brightness multiplier, so lit slopes go golden and shadows cool-blue (the depth cue that makes a range feel alive). - AUTO-SCALED relief — uExag is now derived from the measured height span (~0.11 of the frame) instead of a hardcoded 15. Iceland (span ~0.0074) → ~15 (matches the old hand-tuned value); the Grand Canyon (span ~0.05, far deeper relative to its extent) → ~2.2. The first canyon screenshot rendered its steep walls as an over-exaggerated needle curtain at 15×; auto-scaling makes walls read as walls. (Caught and fixed in the visual-verify loop.) Scene wiring: canyon.v8grid.soa.gz (the garmin_bake output for the Grand Canyon village tile, 626 KB gz) staged into cockpit/public + a garmin_scenes manifest entry, so /garmin/grand-canyon renders through the already-merged mod-rewrite route. A Dockerfile bake-from-.img step (like Iceland's) is a follow-up for reproducibility. Verified: /garmin/grand-canyon renders a recognizable Grand Canyon — mesa plateau, the gorge with side canyons and layered walls, the drainage network visible as the Stream-KIND overlay, warm sunset light, cool sky. /garmin/iceland unchanged in relief (no regression); it retains some needles on its steepest true-scale coastal cliffs (a v8grid artifact at ~15× — milder than the canyon's original, noted). tsc + vite build clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012jEwwaT5JZ5x8qWvcnaMYC
|
Warning Review limit reached
Next review available in: 46 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_88a5ca8c-8638-47c0-9766-1abc66631689) |
2 participants
The map-shader improvements, landing in the
GeoHelixfork (PR #92) so they carry zero risk to the/helixanatomy body. Every change was verified by real headless-swiftshader screenshots of/garmin/grand-canyonand/garmin/iceland.Shader (the
uGeoterrain path only — anatomy path kept byte-identical)terrainColor()), so elevation reads as colour: green lowland → brown → grey → white peak.uExagis now derived from the measured height span (target ~0.11 of the frame) instead of a hardcoded15. Iceland (span ~0.0074) → ~15 (reproduces the old hand-tuned value); the Grand Canyon (span ~0.05, far deeper relative to its extent) → ~2.2.The visual-verify loop earned its keep
The first
/garmin/grand-canyonscreenshot rendered the steep canyon walls as an over-exaggerated needle curtain —15×is right for Iceland's tiny true-scale span but ~7× too much for the canyon. Auto-scaling by the measured span fixed it: the second screenshot shows a recognizable Grand Canyon — mesa plateau, the gorge with side canyons and layered walls, the drainage network visible as the Stream-KIND overlay winding down the canyon floor, warm sunset light raking the walls, hypsometric tint, cool sky. Walls read as walls.Scene wiring
canyon.v8grid.soa.gz— thegarmin_bakeoutput for the Grand Canyon village tile (864,256 verts, 626 KB gz) — staged intocockpit/publicplus agarmin_scenesmanifest entry, so/garmin/grand-canyonrenders through the already-merged mod-rewrite route. (ADockerfilebake-from-.imgstep, like Iceland's, is a follow-up for reproducibility.)Verify
npx tsc --noEmit+vite buildclean./garmin/grand-canyon— screenshot-confirmed (the recognizable canyon described above)./garmin/iceland— screenshot-confirmed, relief unchanged (auto-scale gives it ~14.9 ≈ its old 15, no regression). Honest note: the v8-grid Iceland retains some needles on its steepest true-scale coastal cliffs at ~15× — milder than the canyon's original, and a property of that compact grid artifact, not of this change.Deliberate non-goals (follow-ups)
Kurvenlineal brightness (the removed in-shader GLSL hash was deliberate — the residue is a bake/decode concern, not a re-added shader approximation) and Ice/Ocean specular sun-glint (needs a per-vertex KIND attribute — a decoder change). Both are cleaner as their own change.
🤖 Generated with Claude Code
https://claude.ai/code/session_012jEwwaT5JZ5x8qWvcnaMYC
Generated by Claude Code