feat: support expiring role assignments - #313
Open
Tsammie wants to merge 1 commit into
Open
Conversation
Contributor
|
This PR cannot be merged automatically because one or more workflow checks failed. Please review the failed checks, push a fix, and wait for the workflows to pass. After the checks pass and there are no merge conflicts, the automation can review it again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expiresAtsupport to role assignment input.expiresAtthrough role assignment creation so time-limited roles can be persisted.expiresAtvalues using the existing API validation style.Notes
This PR keeps the change focused on role assignment expiry support. It does not refactor the policy engine or address the existing duplicate role-resolution logic separately.
Checks
expiresAtassignments can grant accessexpiresAtinput is rejectedgit diff --checkCloses #138