Skip to content

fix(deps): resolve unresolved merge-conflict markers in package.json - #406

Open
thlpkee20-wq wants to merge 1 commit into
Agentpay-Org:mainfrom
thlpkee20-wq:fix/package-json-merge-conflict
Open

fix(deps): resolve unresolved merge-conflict markers in package.json#406
thlpkee20-wq wants to merge 1 commit into
Agentpay-Org:mainfrom
thlpkee20-wq:fix/package-json-merge-conflict

Conversation

@thlpkee20-wq

Copy link
Copy Markdown
Contributor

Summary

main currently has literal <<<<<<</=======/>>>>>>> conflict markers
left in devDependencies from the pr-404 merge, making package.json
invalid JSON and breaking npm install for every contributor (including
every other PR in this GrantFox campaign).

Fix

Resolved to typescript@^6.0.3 + typescript-eslint@^8.65.0. The
currently published typescript-eslint (8.65.0) declares a peer range of
typescript >=4.8.4 <6.1.0, so pairing it with the typescript@^7.0.2 side
of the conflict leaves the dependency tree unresolvable (ERESOLVE).
Regenerated package-lock.json accordingly.

Test plan

  • npm install resolves cleanly (no ERESOLVE)
  • npm run build
  • npm run lint
  • npm test (ran the suite; all executed cases passed)

This is a build-blocking prerequisite fix, not tied to a specific GrantFox
issue.

The pr-404 merge left literal <<<<<<</=======/>>>>>>> markers in
devDependencies, producing invalid JSON and breaking npm install for
every contributor. Resolves to typescript@^6.0.3 with
typescript-eslint@^8.65.0: the currently published typescript-eslint
(8.65.0) only supports typescript <6.1.0, so pairing it with the
typescript@^7.0.2 side of the conflict leaves the dependency tree
unresolvable.
@mikewheeleer

Copy link
Copy Markdown
Contributor

thanks @thlpkee20-wq! please add a Closes #<issue> line to the PR description so it links to the issue it resolves — then we can review and merge. 🙏

@mikewheeleer

Copy link
Copy Markdown
Contributor

thanks @thlpkee20-wq! please add a Closes #<issue> line to the PR description so it links to the issue it resolves — then we can review and merge. 🙏

2 similar comments
@mikewheeleer

Copy link
Copy Markdown
Contributor

thanks @thlpkee20-wq! please add a Closes #<issue> line to the PR description so it links to the issue it resolves — then we can review and merge. 🙏

@mikewheeleer

Copy link
Copy Markdown
Contributor

thanks @thlpkee20-wq! please add a Closes #<issue> line to the PR description so it links to the issue it resolves — then we can review and merge. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants