refactor(metrics): extract shared cursor-pagination helper - #415
Merged
mikewheeleer merged 1 commit intoJul 28, 2026
Merged
Conversation
The health/deep checks handler inlined its own base64url cursor encode/decode and page-slicing logic. Extracted it into a generic paginateByCursor() in src/cursorPagination.ts (mirroring the offset pagination helper already shared between the api-keys and webhooks list endpoints) and refactored the health handler to use it. No behavior change; this is the shared entry point subsequent metrics pagination work will build on.
This was referenced Jul 28, 2026
Contributor
|
polished work @thlpkee20-wq, merging it in 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #391
The
/api/v1/health/deepchecks handler inlined its own base64urlcursor encode/decode and page-slicing logic. Extracted it into a
generic
paginateByCursor()insrc/cursorPagination.ts— mirroringthe offset-pagination helper already shared between the api-keys and
webhooks list endpoints — and refactored the health handler to use it.
No behavior change; this is the shared entry point the metrics
pagination work (#387) builds on next.
Test plan
npm run buildnpm run lintnpm test— targeted run ofhealth-deep.test.js,openapi-routes.test.js,routes/operational.test.js: 12/12passing, no behavior change.