refactor(webhooks): extract shared offset-pagination helper - #420
Merged
mikewheeleer merged 1 commit intoJul 28, 2026
Merged
Conversation
The GET /api/v1/webhooks handler inlined the same limit/offset parsing and slicing preamble duplicated in the api-keys list handler. Extracted it into applyOffsetPage() in src/listPagination.ts as a single reusable entry point; behavior is unchanged (same defaults, same response shape).
Contributor
|
looks good @thlpkee20-wq — well scoped and easy to review. merging 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #381
GET /api/v1/webhooksinlined the same limit/offset parsing andslicing preamble duplicated in the api-keys list handler. Extracted it
into
applyOffsetPage()insrc/listPagination.tsas a single reusableentry point consumed by the webhooks handler. Pure refactor — same
defaults (
limitdefaults to the full result set,offsetdefaults to0), same response shape (
{ items, total }).Note:
src/routes/apiKeys.tsin the actual merged history alreadyintroduces this same helper independently (api-keys PR #410) since both
were built in parallel; whichever merges second will need a small
rebase to avoid a duplicate
listPagination.ts, but the twoimplementations are identical so it's a no-op resolve.
Test plan
npm run buildnpm run lintnpm test— targeted run oflist-pagination.test.js,apikeys-webhooks.test.js,webhook-event-validation.test.js,webhook-get-one.test.js,webhook-validator.test.js,routes/operational.test.js: 36/36 passing, no behavior change.