test(admin): cover cancel_admin_transfer auth and idempotency boundaries - #319
Merged
mikewheeleer merged 1 commit intoJul 28, 2026
Merged
Conversation
cancel_admin_transfer had no direct test coverage for two boundaries that every other admin-gated entrypoint in the i22 series already covers: - unauthorized caller: cancel_admin_transfer_requires_admin_auth - idempotent no-op: cancelling with nothing pending must not panic, and must leave both Admin and PendingAdmin unchanged
Contributor
|
@thlpkee20-wq clean implementation, merging with thanks 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #304
The admin logic already has extensive boundary coverage (the `test_i22_`
series covers auth-required for every other admin-gated entrypoint;
`test_i20_` covers propose/accept/cancel interactions). Two boundaries
specific to `cancel_admin_transfer` had no direct test:
every other `test_i22_*` entrypoint, but had no matching auth test.
and must leave both `Admin` and `PendingAdmin` unchanged — mirrors
the idempotency contract already documented and tested for
`pause`/`unpause`.
Test plan
pre-existing, unrelated test covered by fix(test): correct cross-call event-count assumption in ownership-transfer test #315.