feat(storage): emit state-change event - #431
Merged
mikewheeleer merged 2 commits intoJul 28, 2026
Merged
Conversation
env.events().all() reflects only the most recent contract invocation, not a running total across separate calls (consistent with every other event test in this file). The test compared post-transfer event count against a pre-transfer count captured after a *different* call (set_service_metadata), expecting accumulation that never happens, so it failed on every run regardless of contract behavior. Fixed to assert directly on this call's own event count.
Jagadeeshftw
force-pushed
the
feature/storage-02-event
branch
from
July 28, 2026 21:17
9cc2191 to
0a7971a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set_agent_allowedandset_agent_blockedwriteDataKey::AgentAllowed/DataKey::AgentBlockedbut were the only per-agent boolean setters that emitted no event — every sibling setter (set_allowlist_enabled,set_require_service_registration, etc.) already publishes acfg_setevent on write.set_agent_allowednow emitsagt_alw(agent, allowed)after the storage write.set_agent_blockednow emitsagt_blk(agent, blocked)after the storage write.symbol_short!9-char limit, and distinct from every existing topic (no collision).Tests added
test_set_agent_allowed_emits_agt_alw_event— payload correctness on first calltest_set_agent_allowed_emits_event_on_every_toggle— a second, independent call emits its own event with the new valuetest_set_agent_blocked_emits_agt_blk_event— payload correctness on first calltest_set_agent_blocked_emits_event_on_every_toggle— same for the blocklist settertest_agt_alw_and_agt_blk_topics_do_not_collide— the two new topics are captured independently and never conflatedCloses #287
Validation
cargo fmt --all -- --checkcargo clippy --all-targets -- -D warningscargo test -p escrow— 357 passed (5 new), 1 pre-existing failure unrelated to this change (test_transfer_service_ownership_genuine_transfer_emits_event, fails identically onmain)