feat(events): add a read view for the usage-alert threshold - #435
Merged
mikewheeleer merged 2 commits intoJul 29, 2026
Conversation
env.events().all() reflects only the most recent contract invocation, not a running total across separate calls (consistent with every other event test in this file). The test compared post-transfer event count against a pre-transfer count captured after a *different* call (set_service_metadata), expecting accumulation that never happens, so it failed on every run regardless of contract behavior. Fixed to assert directly on this call's own event count.
Jagadeeshftw
force-pushed
the
feature/events-01-view
branch
from
July 28, 2026 21:19
8d5bb5d to
2a9e081
Compare
Contributor
|
nice one @Jagadeeshftw, checks pass. merging 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DataKey::UsageAlertThresholddrives the edge-triggeredusage_hialert insiderecord_usage, but no entrypoint could read or write it — the slot was permanently absent, sorecord_usagealways used theunwrap_or(0)default and the alert path was unreachable on any live deploy.get_usage_alert_threshold() -> u32, a pure read (defaults to0, matching the existingunwrap_orinrecord_usage).set_usage_alert_threshold(threshold), admin-gated, following the same shape as every other scalar admin setting (set_max_requests_per_window, etc.). Emitscfg_set(alert_thr, threshold)— the tag is deliberately distinct from theusage_hievent topic itself so the two are never conflated by a listener.record_usage's existing crossing logic — this only makes the threshold configurable.Tests added
test_get_usage_alert_threshold_defaults_to_zerotest_set_usage_alert_threshold_round_triptest_set_usage_alert_threshold_emits_cfg_set_eventtest_set_usage_alert_threshold_requires_admin_authtest_usage_hi_fires_once_threshold_now_settable— end-to-end: below-threshold call emits nothing, the crossing call emits exactly oneusage_hiwith the correct payload, and a subsequent above-threshold call emits nothing (edge-triggered)test_usage_hi_disabled_by_default_zero_threshold— confirms the alert stays off when the threshold is left at its defaultCloses #288
Validation
cargo fmt --all -- --checkcargo clippy --all-targets -- -D warningscargo test -p escrow— 358 passed (6 new), 1 pre-existing failure unrelated to this change (test_transfer_service_ownership_genuine_transfer_emits_event, fails identically onmain)