feat(fees): add a combined read view for a service's pricing state - #436
Merged
mikewheeleer merged 2 commits intoJul 29, 2026
Merged
Conversation
env.events().all() reflects only the most recent contract invocation, not a running total across separate calls (consistent with every other event test in this file). The test compared post-transfer event count against a pre-transfer count captured after a *different* call (set_service_metadata), expecting accumulation that never happens, so it failed on every run regardless of contract behavior. Fixed to assert directly on this call's own event count.
Jagadeeshftw
force-pushed
the
feature/fees-01-view
branch
from
July 28, 2026 21:19
7a03b44 to
3df6ba1
Compare
Contributor
|
clean work @Jagadeeshftw — CI green, merging 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A service's full pricing configuration is spread across four independent reads:
get_service_price,get_price_tiers,get_min_service_price/get_max_service_price, andis_service_disabled. Addsget_service_pricing(service_id) -> ServicePricing, bundling all of it into one round trip — following the same convenience-snapshot pattern already used byget_admin_summaryandget_billing_summary.ServicePricing { price_stroops, tiers, min_bound, max_bound, disabled }.require_auth, no pause gate, no storage writes.docs/escrow/pricing.mdfor the tiers-vs-bounds asymmetry so a caller reading this struct sees the caveat inline, not just in prose docs.Tests added
test_get_service_pricing_defaults_for_never_configured_servicetest_get_service_pricing_reflects_flat_pricetest_get_service_pricing_reflects_tier_scheduletest_get_service_pricing_reflects_global_boundstest_get_service_pricing_reflects_disabled_flagtest_get_service_pricing_matches_individual_getters— cross-checks every field against its dedicated getter for a service configured with all axes at onceCloses #293
Validation
cargo fmt --all -- --checkcargo clippy --all-targets -- -D warningscargo test -p escrow— 358 passed (6 new), 1 pre-existing failure unrelated to this change (test_transfer_service_ownership_genuine_transfer_emits_event, fails identically onmain)