a11y(settings): announce theme updates politely - #449
Open
emirykl wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test evidence
npm test -- --no-watchman --runInBand src/components/__tests__/ThemeToggle.test.tsx src/app/settings/page.test.tsx— passed, 10/10 testsThemeToggle.tsxnpm run build— passedgit diff --check— passeduseApi,apiClienttests, andvalidateNumbertestsFixes #411
Verification
PASS: focused settings tests — 10/10PASS: focused ESLintPASS: ThemeToggle coverage — 100% statements, branches, functions, and linesPASS: npm run buildPASS: git diff --checkBASELINE FAILURE: full Jest — 75 suites passed, 2 unrelated suites failed (API keys and theme SSR tests)BASELINE FAILURE: repository lint — 3 existing errors in service edit/useApi filesBASELINE FAILURE: typecheck — 5 existing errors in apiClient/validateNumber testsDiagnostics
Recovered command failures:
/bin/zsh -lc 'npm ci --ignore-scripts'(255),/bin/zsh -lc 'npm test -- --no-watchman --runInBand src/components/__tests__/ThemeToggle.test.tsx --coverage --collectCoverageFrom=src/components/ThemeToggle.tsx'(1),/bin/zsh -lc 'npm run typecheck'(2),/bin/zsh -lc 'npm run lint'(1),/bin/zsh -lc 'npm test -- --no-watchman --runInBand'(1)