Fix off-by-one shot resolution; /fix sends the chart photo#29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Field bug (morning of 2026-07-09): a shot index entry is only flagged completed after extended recording (up to ~1min of scale settling), while older completed-but-unclaimed entries (e.g. an aborted 8s shot) already sit in the index — so newest-completed resolution returned the PREVIOUS shot, and every questionnaire ran one shot behind. Resolution now requires the candidate to match the observed shot duration (±10s), keeps waiting for the real entry, and only falls back to newest-completed (loudly) when the budget expires. Resolved ids are logged at INFO. Also: /fix now renders and sends the shot chart like a live questionnaire.