Skip to content

[PWGEM/Dilepton] add dilepton with SV#16626

Merged
dsekihat merged 4 commits into
AliceO2Group:masterfrom
dsekihat:master
Jun 11, 2026
Merged

[PWGEM/Dilepton] add dilepton with SV#16626
dsekihat merged 4 commits into
AliceO2Group:masterfrom
dsekihat:master

Conversation

@dsekihat

Copy link
Copy Markdown
Collaborator

[PWGEM/Dilepton] add dilepton with SV

@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 135 errors, ⚠️ 247 warnings, 🔕 0 disabled

[PWGEM] Please consider the following formatting changes to AliceO2Group#16626
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 015b1e8 at 2026-06-11 22:01:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGEM/Dilepton/Core/DileptonSV.h:1174:13: error: unused variable 'opAng' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGEM/Dilepton/Core/DileptonSV.h:1174:13: error: unused variable 'opAng' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 015b1e8 at 2026-06-11 22:06:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGEM/Dilepton/Core/DileptonSV.h:1174:13: error: unused variable 'opAng' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGEM/Dilepton/Core/DileptonSV.h:1174:13: error: unused variable 'opAng' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

Commented out the calculation of the opening angle in DileptonSV.h.
@dsekihat dsekihat enabled auto-merge (squash) June 11, 2026 20:11

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @dsekihat.

@dsekihat dsekihat merged commit d57f8d3 into AliceO2Group:master Jun 11, 2026
13 of 14 checks passed
@vkucera

vkucera commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

PWGEM/Dilepton/Core/DileptonSV.h

PWGEM/Dilepton/Core/DileptonSV.h:91:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
PWGEM/Dilepton/Core/DileptonSV.h:115:8: warning: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init]
PWGEM/Dilepton/Core/DileptonSV.h:379:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/DileptonSV.h:421:7: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGEM/Dilepton/Core/DileptonSV.h:422:7: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGEM/Dilepton/Core/DileptonSV.h:438:7: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGEM/Dilepton/Core/DileptonSV.h:439:7: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGEM/Dilepton/Core/DileptonSV.h:455:7: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGEM/Dilepton/Core/DileptonSV.h:456:7: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGEM/Dilepton/Core/DileptonSV.h:473:7: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGEM/Dilepton/Core/DileptonSV.h:474:7: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGEM/Dilepton/Core/DileptonSV.h:546:39: warning: use nullptr [modernize-use-nullptr]
PWGEM/Dilepton/Core/DileptonSV.h:547:43: warning: use nullptr [modernize-use-nullptr]
PWGEM/Dilepton/Core/DileptonSV.h:602:25: warning: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast]
PWGEM/Dilepton/Core/DileptonSV.h:623:11: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/DileptonSV.h:918:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGEM/Dilepton/Core/DileptonSV.h:969:25: warning: no header providing "std::runtime_error" is directly included [misc-include-cleaner]
PWGEM/Dilepton/Core/DileptonSV.h:1063:149: warning: the const qualified parameter 'weightvector' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param]
PWGEM/Dilepton/Core/DileptonSV.h:1068:9: warning: if with identical then and else branches [bugprone-branch-clone]
PWGEM/Dilepton/Core/DileptonSV.h:1494:13: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/DileptonSV.h:1507:13: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/DileptonSV.h:1612:24: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGEM/Dilepton/Core/DileptonSV.h:1639:39: warning: repeated branch body in conditional chain [bugprone-branch-clone]
PWGEM/Dilepton/Core/DileptonSV.h:1723:7: warning: if with identical then and else branches [bugprone-branch-clone]
PWGEM/Dilepton/Core/DileptonSV.h:1755:105: warning: repeated branch body in conditional chain [bugprone-branch-clone]
PWGEM/Dilepton/Core/DileptonSV.h:1776:13: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants