fix(PoolTable): relabel footer total to 'Total (visible rows)' - #420
Merged
Jagadeeshftw merged 1 commit intoJul 30, 2026
Merged
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(PoolTable): disambiguate footer total label
Summary
Relabels the PoolTable row from "Total" to "Total (visible rows)" to
match the existing precedent in SettlementTable.
On /dashboard, the StatCard labelled "Total liquidity" is computed from the
full, unfiltered pool list, while the table footer total is computed from only
the pools currently passed in — which can be a filtered subset when the user
has typed in the search box. Previously both were labelled the same way,
making it easy to mistake the filtered table total for the full network total.
No change to either total's underlying calculation — label only.
Changes
rows)"
label
Testing
Existing test "renders a totals row summing liquidity and anchor count"
updated to assert "Total (visible rows)". All other PoolTable tests
are unaffected.
close #262