Cleanup: remove vestigial ble_firmware sub; fix build.yml device-name#101
Conversation
The ble_firmware substitution is no longer read by anything after the runtime Bluetooth Proxy switch replaced the firmware_ble manifest selector (#100) - remove it from Core.yaml and MSR-1_BLE.yaml. Also correct the copy-pasted device-name input in build.yml (msr-2 -> msr-1); it is a required-but-unused input in the shared workflow, so this is a no-op correctness fix. No compiled-output change; does not publish. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
|
Warning Review limit reached
Next review available in: 2 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Version: 26.7.9.1 (no change — no-publish cleanup)
What does this implement/fix?
Small cleanup after the unified-firmware change (#100):
ble_firmwaresubstitution. Nothing reads${ble_firmware}anymore — the runtime "Bluetooth Proxy" switch replaced the oldfirmware_blemanifest selector, and the on-boot lambda that consumed it is gone. Removed fromCore.yamlandMSR-1_BLE.yaml. Compiled output is identical.device-nameinbuild.yml(msr-2→msr-1). It's a required-but-unused input in the sharedApolloAutomation/Workflowsbuild workflow (declared, never consumed), so this is a no-op correctness fix — the wrong value never affected any published path.No firmware behavior change; does not publish.
Types of changes
Checklist / Checklijst:
If user-visible functionality or configuration variables are added/modified:
🤖 Generated with Claude Code