Skip to content

Remove unneeded pre-OTA BLE disable from Firmware Update#103

Merged
bharvey88 merged 1 commit into
betafrom
remove/ble-stop-before-ota
Jul 9, 2026
Merged

Remove unneeded pre-OTA BLE disable from Firmware Update#103
bharvey88 merged 1 commit into
betafrom
remove/ble-stop-before-ota

Conversation

@bharvey88

Copy link
Copy Markdown
Contributor

Version: 26.7.9.1 (no change — part of the single release)

What does this implement/fix?

Removes the logic that dropped the BLE stack before an OTA and re-enabled/re-applied the scan afterward, from the Firmware Update button.

Verified on hardware: the unified build (~21% RAM at rest, ~260 KB free) completes the TLS firmware download with the Bluetooth proxy still active, so freeing RAM by disabling BLE first isn't needed. The proxy now stays up through the update — simpler flow, no BLE interruption.

Kept the two delay steps (manifest-fetch timing). The delay: 3s previously let the BLE disable settle; it's a harmless brief pause now — happy to drop it too if you'd prefer.

Types of changes

  • Bugfix (fixed change that fixes an issue)
  • New feature (thanks!)
  • Breaking change (repair/feature that breaks existing functionality)
  • Dependency Update - Does not publish
  • Other - Does not publish
  • Website of github readme file update - Does not publish
  • Github workflows - Does not publish

Checklist / Checklijst:

  • The code change has been tested and works locally
  • The code change has not yet been tested

If user-visible functionality or configuration variables are added/modified:

  • Added/updated documentation for the web page

🤖 Generated with Claude Code

Verified on hardware that the unified build (~21% RAM at rest, ~260 KB
free) completes the TLS firmware download with the Bluetooth proxy still
active, so freeing RAM by dropping the BLE stack before the update is
unnecessary. Remove the disable-before / re-enable-and-restore-scan-after
logic; the Bluetooth proxy now stays up through the update.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@bharvey88, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 1 minute

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5661dc09-631e-420c-84bb-183266e6bbcf

📥 Commits

Reviewing files that changed from the base of the PR and between bd24876 and 9de835c.

📒 Files selected for processing (1)
  • Integrations/ESPHome/Core.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove/ble-stop-before-ota

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant