Skip to content

Re-point beta-fw tag on every beta publish#106

Open
bharvey88 wants to merge 1 commit into
betafrom
fix/beta-fw-tag-repoint
Open

Re-point beta-fw tag on every beta publish#106
bharvey88 wants to merge 1 commit into
betafrom
fix/beta-fw-tag-repoint

Conversation

@bharvey88

@bharvey88 bharvey88 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Version: unchanged (workflow only)

What does this implement/fix?

The rolling beta-fw release tag was stuck on the commit that was default-branch HEAD when the release was first created (gh release create without --target tags default-branch HEAD, and gh release upload never moves the tag). The published assets tracked every beta build while the release's source commit did not, so the release page and its source archives pointed at the wrong tree.

Adds a step to build-beta.yml that PATCHes the beta-fw tag ref to the built commit after each upload, so the tag always matches the assets.

Types of changes

  • Bugfix (fixed change that fixes an issue)
  • New feature (thanks!)
  • Breaking change (repair/feature that breaks existing functionality)
  • Dependency Update - Does not publish
  • Other - Does not publish
  • Website of github readme file update - Does not publish
  • Github workflows - Does not publish

Checklist / Checklijst:

  • The code change has been tested and works locally
  • The code change has not yet been tested

If user-visible functionality or configuration variables are added/modified:

  • Added/updated documentation for the web page

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Improved beta release publishing so the rolling beta release consistently points to the exact build used for its assets.
    • Reduced the risk of mismatched firmware files and release metadata during beta updates.

The rolling beta-fw release tag stays on the commit that was default-branch
HEAD when the release was first created. gh release create without --target
tags default-branch HEAD, and gh release upload never moves the tag, so the
published assets track every beta build while the release source commit does
not.

Add a step to build-beta.yml that PATCHes the beta-fw tag ref to the built
commit after each upload, so the tag always matches the assets.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Failed to post review comments.

We encountered an issue with GitHub. Use @coderabbitai full review to retry the review.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5d4d26a0-4402-47ab-862c-d2a223a69aa2

📥 Commits

Reviewing files that changed from the base of the PR and between 0b69a22 and 2b18555.

📒 Files selected for processing (1)
  • .github/workflows/build-beta.yml
⏰ Context from checks skipped due to timeout. (9)
  • GitHub Check: CI / Building Integrations/ESPHome/MSR-1_BLE.yaml / ESPHome dev
  • GitHub Check: CI / Building Integrations/ESPHome/MSR-1.yaml / ESPHome dev
  • GitHub Check: CI / Building Integrations/ESPHome/MSR-1.yaml / ESPHome beta
  • GitHub Check: CI / Building Integrations/ESPHome/MSR-1_Factory.yaml / ESPHome stable
  • GitHub Check: CI / Building Integrations/ESPHome/MSR-1_BLE.yaml / ESPHome stable
  • GitHub Check: CI / Building Integrations/ESPHome/MSR-1.yaml / ESPHome stable
  • GitHub Check: CI / Building Integrations/ESPHome/MSR-1_Factory.yaml / ESPHome dev
  • GitHub Check: CI / Building Integrations/ESPHome/MSR-1_Factory.yaml / ESPHome beta
  • GitHub Check: CI / Building Integrations/ESPHome/MSR-1_BLE.yaml / ESPHome beta

Walkthrough

The beta release workflow now force-updates the rolling beta-fw tag to the commit used to build and publish the beta firmware assets.

Changes

Beta release publishing

Layer / File(s) Summary
Repoint the beta-fw tag after publishing
.github/workflows/build-beta.yml
Adds a final workflow step that patches the beta-fw Git reference to ${{ github.sha }} with force=true and logs the mapping.

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related PRs

Poem

A bunny watched the beta tag fly,
Then nudged it to the commit nearby.
Assets bloomed, the refs aligned,
No stray branch was left behind.
Hop, hop—release time!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main workflow change: repointing the beta-fw tag on each beta publish.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/beta-fw-tag-repoint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant