Skip to content

copy: Corrected touch target boundaries for various chart types#794

Open
hannesa2 wants to merge 3 commits into
masterfrom
stacked-bar-highlighter
Open

copy: Corrected touch target boundaries for various chart types#794
hannesa2 wants to merge 3 commits into
masterfrom
stacked-bar-highlighter

Conversation

@hannesa2

@hannesa2 hannesa2 commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

This is a copy of #791 on upstream.
This enables screenshot compare mechanism @venkatbhoogarbh

@hannesa2 hannesa2 force-pushed the stacked-bar-highlighter branch 4 times, most recently from b3119e5 to e2036c3 Compare June 19, 2026 14:23
@hannesa2

Copy link
Copy Markdown
Collaborator Author

Screenshot differs: emulatorApi=9 with 11 screenshot(s)

setpoint (old) | diff | actual screenshot (new)

StartTest_smokeTestStart-15-BarChartPositiveNegative-Negative-click.pngscreenshot

StartTest_smokeTestStart-15-BarChartPositiveNegative-Negative-click2020.pngscreenshot

StartTest_smokeTestStart-25-CombinedChartActivity-CombinedChart-click2020.pngscreenshot

StartTest_smokeTestStart-31-ListViewMultiChartActivity-Multiple-click2020.pngscreenshot

StartTest_smokeTestStart-6-LineChartColoredActivity-Colorful-click2020.pngscreenshot

StartTest_smokeTestStart-7-PerformanceLineChart-Performance-click.pngscreenshot

StartTest_smokeTestStart-7-PerformanceLineChart-Performance-click2020.pngscreenshot

StartTest_smokeTestStart-7-PerformanceLineChart-Performance-click7070.pngscreenshot

StartTest_smokeTestStart-8-FilledLineActivity-Filled-click.pngscreenshot

StartTest_smokeTestStart-8-FilledLineActivity-Filled-click2020.pngscreenshot

StartTest_smokeTestStart-8-FilledLineActivity-Filled-click7070.pngscreenshot

@hannesa2

Copy link
Copy Markdown
Collaborator Author

As you @venkatbhoogarbh can see, the click changes here something. Is this a desired behavior ?

@hannesa2 hannesa2 changed the title Stacked bar highlighter copy: Corrected touch target boundaries for various chart types Jun 19, 2026
@venkatbhoogarbh

Copy link
Copy Markdown

The lint checks look good now! I see the screenshot test caught the visual differences caused by the stacked-bar highlighting fix. Since forks don't have permission to modify the baseline snapshot files directly, let me know if you need any other changes from my side, or if this copy is good to go!

@hannesa2 hannesa2 force-pushed the stacked-bar-highlighter branch from 253cb01 to 793eb42 Compare June 22, 2026 13:54
@hannesa2

hannesa2 commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator Author

The lint checks look good now! I see the screenshot test caught the visual differences caused by the stacked-bar highlighting fix. Since forks don't have permission to modify the baseline snapshot files directly, let me know if you need any other changes from my side, or if this copy is good to go!

The lint is still failing.

This is just to verify the screenshot test mechanism.
Option 1: I would love when you accept my invite, push your branch to upstream and create a new pull request:
pro: you have the honor of the source of the contribution

Option 2: I would love when you accept my invite, and continue here
con: I'm the source of the contribution, but it's not my work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants