Add domain selection + optional prefix to CanopyPrometheusVisitor - #26
Merged
Conversation
The Prometheus export now supports choosing which domains to export and optionally prefixing a domain's metric names, mirroring the old pharo-metrics namespacing (image/virtualMachine under a `pharo` group, apptiveGrid bare) without coupling domain nodes to how they are exported. - addDomain: / addDomain:prefix: configure the export selection. - export formats only the configured domains, each with its optional prefix. - convertMetricName: prepends the current prefix; format: is unchanged (currentPrefix nil -> bare fullKey), so existing callers keep their behavior. Prefix is an export-time concern held on the visitor, never on the domain. Canopy-Metrics-Tests 16/16, Canopy-Core-Tests 73/73 green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Prometheus export now supports choosing which domains to export and optionally prefixing a domain's metric names, mirroring the old pharo-metrics namespacing (image/virtualMachine under a
pharogroup, apptiveGrid bare) without coupling domain nodes to how they are exported.Prefix is an export-time concern held on the visitor, never on the domain.
Canopy-Metrics-Tests 16/16, Canopy-Core-Tests 73/73 green.