Make CanopyMetricsHandler configurable with domain selection + prefix - #27
Merged
Conversation
Builds on the visitor's addDomain:/addDomain:prefix: API. The handler now lets a caller choose which domains the scrape endpoint exports and optionally prefix a domain's metric names (e.g. #virtualMachine prefix: 'pharo'). - addDomain: / addDomain:prefix: configure the selection (domain names as symbols). - prometheusText resolves each configured domain fresh per request (values stay live), then exports via the visitor. - Default is unchanged: with no domains configured, the whole Canopy tree is exported (all domains, unprefixed) exactly as before. Canopy-Metrics-Tests 20/20, Canopy-Core-Tests 73/73 green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on the visitor's addDomain:/addDomain:prefix: API. The handler now lets a caller choose which domains the scrape endpoint exports and optionally prefix a domain's metric names (e.g. #virtualMachine prefix: 'pharo').
Canopy-Metrics-Tests 20/20, Canopy-Core-Tests 73/73 green.