Render branches as an HTML list of child links in CanopyBrowseHtmlHan… - #28
Merged
Conversation
…dler A branch now renders as an HTML page (title + one link per child node) when Accept: text/html, instead of falling back to JSON. Leaf rendering (value + edit form) is unchanged; PUT on a branch still delegates to the JSON handler. Child links are absolute (/<path>/<key>), which sidesteps the trailing-slash relative-resolution issue that had this deferred - no canonicalization needed. - handleHtmlRequest: branch + GET -> branchPageFor:path:. - branchPageFor:path: / childHref:key: added. - The old "branch stays JSON even with html Accept" test is replaced by tests for the list rendering, absolute nested child links, and branch-stays-JSON when Accept is not html. Note: tests were written but NOT executed in this session (Pharo MCP was unavailable here) - verification still pending. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…dler
A branch now renders as an HTML page (title + one link per child node) when Accept: text/html, instead of falling back to JSON. Leaf rendering (value + edit form) is unchanged; PUT on a branch still delegates to the JSON handler.
Child links are absolute (//), which sidesteps the trailing-slash relative-resolution issue that had this deferred - no canonicalization needed.
Note: tests were written but NOT executed in this session (Pharo MCP was unavailable here) - verification still pending.