Fix gateway condition scope wrapping - #81
Merged
Merged
Conversation
testAllExposedNodeClassesHaveATypeName called FBNode class>>exposedNodes, which is an ApptiveBase-Core extension (exposedNodeClasses/exposedNodes/ withType: all live there, not in FluxBase-Core), so it only worked in a shared image with both packages loaded. FluxBase's own CI (Core + Core-Tests + Roassal only) hit a genuine doesNotUnderstand, exactly what the test was trying to guard against -- just for the wrong reason. Rewrote the test to check the same invariant (every non-abstract FBNode subclass responds to #typeName) using only FluxBase-Core primitives (allSubclasses/isAbstract/typeName), without needing the ApptiveBase-Core collector methods.
FBExclusiveGatewayBehavior/FBMultiChoiceGatewayBehavior called transition conditionMatches: directly during the "which transitions match" selection phase, bypassing the activation entirely. This is the hook AGFlowActivation (ApptiveBase-Core) overrides to set up the transition's ApptiveScript scope (asApptiveScriptScope activation: self; useDuring:) -- without it, conditions referencing "source" (e.g. 'source.input >= 5') can't resolve and silently evaluate to false via ASNode>>matches:'s ASError-catch. This bug has been latent since the WCP-04 exclusive-gateway rewrite (#54) -- apptive-base's FluxBase pin simply never crossed that commit until now, so it was never exercised. Added FBBaseActivation>>transitionMatches: as the shared hook (default: plain conditionMatches:, no context needed at the FluxBase-Core level), routed both gateway behaviors and FBBaseActivation>>followTransition: withToken: through it instead of calling conditionMatches: directly. AGFlowActivation needs a companion override (not in this repo) to actually restore correct behavior -- see the apptive-base-side commit. Added FBRecordingTransitionActivation (test fixture) plus a characterization test on each gateway behavior proving the hook is actually invoked during selection, not just at follow-time. Verified: FluxBase-Core-Tests 145/146 (1 pre-existing, unrelated FBIdGeneratorTest failure). Proposal only -- do not merge without Norbert's review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.