Fix parallel node nested inside a parallel node crashing/duplicating … - #82
Merged
Conversation
…output FBParallelJoinNodeBehavior popped and resumed the parent parallel executor before enqueueing its own outgoing transition, letting the parent eagerly advance to its next iteration first. The stale transition, once finally processed, was then read back with the outer executor's index against an inner join activation sized to the (smaller) inner list - causing an index-out-of-bounds crash or a value leaked from the wrong outer iteration. FBBaseExecutor>>popThenResume: decouples popping from resuming so the join can enqueue its continuation first. FBParallelExecutor>>lastValueOf: now only re-indexes a value that was actually produced within its own scope, using a nested scope's already-resolved value as-is otherwise. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…output
FBParallelJoinNodeBehavior popped and resumed the parent parallel executor before enqueueing its own outgoing transition, letting the parent eagerly advance to its next iteration first. The stale transition, once finally processed, was then read back with the outer executor's index against an inner join activation sized to the (smaller) inner list - causing an index-out-of-bounds crash or a value leaked from the wrong outer iteration.
FBBaseExecutor>>popThenResume: decouples popping from resuming so the join can enqueue its continuation first. FBParallelExecutor>>lastValueOf: now only re-indexes a value that was actually produced within its own scope, using a nested scope's already-resolved value as-is otherwise.