Make FBTransition duck-type as its own FBWorkItem - #83
Merged
Conversation
FBBaseExecutor>>isCreated (and FBFlowExecutor>>step) read pending entries as FBWorkItem via #transition. FBParallelExecutor's pending queue was deliberately left holding raw transitions when FBWorkItem was introduced (ca0988a), and any FBFlowExecutor pending queue persisted to Soil before that migration still holds raw transitions too. Loading such an instance and computing its state (e.g. via GET .../flows/:id/instances) sent #transition to the raw transition and crashed with MessageNotUnderstood. FBTransition>>transition answers self, so both shapes respond to #transition the same way pending/isCreated already rely on #source and #target working on either shape. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FBBaseExecutor>>isCreated (and FBFlowExecutor>>step) read pending entries as FBWorkItem via #transition. FBParallelExecutor's pending queue was deliberately left holding raw transitions when FBWorkItem was introduced (ca0988a), and any FBFlowExecutor pending queue persisted to Soil before that migration still holds raw transitions too. Loading such an instance and computing its state (e.g. via GET .../flows/:id/instances) sent #transition to the raw transition and crashed with MessageNotUnderstood.
FBTransition>>transition answers self, so both shapes respond to #transition the same way pending/isCreated already rely on #source and #target working on either shape.