Review 8 — Retention model: 24h regeneration window replaces delete-at-issuance - #32
Draft
ArneeMe wants to merge 1 commit into
Draft
Review 8 — Retention model: 24h regeneration window replaces delete-at-issuance#32ArneeMe wants to merge 1 commit into
ArneeMe wants to merge 1 commit into
Conversation
Product decision: admins need to regenerate a PDF after issuing (wrong printer, lost file, typo spotted). Issuing a certificate therefore no longer deletes the submission — the 24h retention sweep (time since creation) is now the single deletion mechanism, issued or not. - Certificates POST no longer deletes; it is idempotent per submission, returning the existing cert on re-issue instead of minting duplicates. - Certificates GET now includes submissionId so the dashboard can mark already-issued submissions with an 'Utstedt' chip after reload and keep them regenerable until expiry. - Dashboard: issued submissions stay in the list (chip + countdown); single and batch flows simplified accordingly. - All copy updated in both languages (dialogs, confirmation screen, landing, /om, /personvern), plus CLAUDE.md (deletion is TIME-based, sweep is load-bearing) and README. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BFHkXUuHJME4cF9AJWbavB
Deploying inf319-certificate with
|
| Latest commit: |
2965e7f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5f78ede1.inf319-certificate.pages.dev |
| Branch Preview URL: | https://claude-review-8-retention-wi.inf319-certificate.pages.dev |
This was referenced Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #31 (part 8 of the review stack). Core-model change per your request — review together with #29, whose delete-at-issuance description this supersedes.
The change
Issuing a certificate no longer deletes the submission. Instead, the 24h retention sweep (time since creation) is the single deletion mechanism — issued or not. Admins can regenerate the PDF any time within the window (wrong printer, lost file, typo spotted late).
How it stays safe
SUBMISSION_TTL_HOURS, one constant). The sweep is documented in CLAUDE.md as load-bearing./om,/personvern, plus CLAUDE.md and README.One trade-off to be aware of
The window is measured from submission, not issuance — a submission issued at hour 23 has only 1h of regeneration left. If you'd rather have "24h after issuance", say so and I'll rework the sweep to track an expiry timestamp instead; that needs a small column migration.
Verification
Typecheck, lint, 110 unit tests, 8 E2E, production build — all green.
🤖 Generated with Claude Code
https://claude.ai/code/session_01BFHkXUuHJME4cF9AJWbavB
Generated by Claude Code