[fix] Clear storage data before releasing controller indexes#137
Merged
Conversation
Previously, the clear operation released the storage unit index in the controller before freeing the underlying storage memory. A concurrent actor could acquire the released index, write new data, and then have that data freed by the trailing storage clear — causing silent data loss and missing-field errors on the index during long training runs. Fix by reversing the order: free storage memory first, then release the index back to the controller's reusable pool. Signed-off-by: yxstev <zhangyixiang9@huawei.com>
CLA Signature Passdodatboii, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
CLA Signature Passdodatboii, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
ji-huazhong
approved these changes
Jul 10, 2026
Collaborator
|
I believe this solution is insufficient. The clear operation needs to be transactional (or atomic). The current ordering introduces a consistency issue: data may be removed from Maybe we can:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the clear operation released the storage unit index in the controller before freeing the underlying storage memory. A concurrent actor could acquire the released index, write new data, and then have that data freed by the trailing storage clear — causing silent data loss and missing-field errors on the index during long training runs.
Fix by reversing the order: free storage memory first, then release the index back to the controller's reusable pool.