Skip to content

fix(identity): reduce noisy client-error logs#14498

Merged
raymondjacobson merged 1 commit into
mainfrom
codex/identity-log-slimming
Jun 23, 2026
Merged

fix(identity): reduce noisy client-error logs#14498
raymondjacobson merged 1 commit into
mainfrom
codex/identity-log-slimming

Conversation

@raymondjacobson

Copy link
Copy Markdown
Member

Summary

  • Move expected identity-service 4xx responses from error logs to debug logs while preserving 5xx responses at error level.
  • Redact sensitive query parameters in request log context and add compact error shaping for axios-style failures.
  • Use the compact error shape for auth backfill failures so dependency errors do not serialize giant request objects.
  • Add helper tests covering 4xx/5xx log levels, query redaction, and compact axios-style error fields.

Context

A live stern -n identity-service . sample showed most app-container log volume coming from expected client-side 400s (/users/check?email= and invalid /authentication credentials). The pasted updateBlockchainIds giant log and repeated download-app email delivery logs come from the older deployed notification runtime; current code has already removed that runtime, and this PR handles the remaining central response/logging path.

Verification

  • node -c packages/identity-service/src/apiHelpers.js && node -c packages/identity-service/src/authMiddleware.js && node -c packages/identity-service/src/logging.js && node -c packages/identity-service/test/apiHelpersTest.js && node -c packages/identity-service/test/index.ts
  • git diff --check

Not run: full npm test -w identity-service; this worktree is missing local workspace test dependencies (../../node_modules/ts-mocha, plus bunyan/mocha). The attempted run created the standard test Postgres/Redis containers before failing, and those containers were removed.

@changeset-bot

changeset-bot Bot commented Jun 23, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ba37d98

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@raymondjacobson raymondjacobson merged commit b04fe78 into main Jun 23, 2026
8 checks passed
@raymondjacobson raymondjacobson deleted the codex/identity-log-slimming branch June 23, 2026 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant