Skip to content

feat(vscode): Enable MI option in connector setup#9390

Open
andrew-eldridge wants to merge 3 commits into
mainfrom
aeldridge/enableMIAuth
Open

feat(vscode): Enable MI option in connector setup#9390
andrew-eldridge wants to merge 3 commits into
mainfrom
aeldridge/enableMIAuth

Conversation

@andrew-eldridge

@andrew-eldridge andrew-eldridge commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

This reverts commit #9364 and enabled managedServiceIdentity auth by default in local.settings.json

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Enable MI auth by default in local.settings.json ('WORKFLOWS_AUTHENTICATION_METHOD': 'managedServiceIdentity')

Impact of Change

  • Users: MI auth option can now be selected in connectors setup
  • Developers: N/A
  • System: N/A

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in:

Contributors

@andrew-eldridge

@andrew-eldridge andrew-eldridge added VSCode Issues or PRs specific to VS Code extension risk:low Low risk change with minimal impact labels Jul 13, 2026
@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: feat(vscode): Enable MI option in connector setup
  • Issue: None — valid feat(scope): prefix and descriptive.
  • Recommendation: No change needed.

Commit Type

  • Exactly one type selected: feat - New functionality.
  • Matches the title prefix and the code changes (new default auth behavior).

Risk Level

  • You declared Low (body + risk:low label), but this PR changes shipped VS Code extension runtime behavior in apps/vs-code-designer — it flips the default connector authentication to managedServiceIdentity (WORKFLOWS_AUTHENTICATION_METHOD) in local.settings.json, removes the AuthenticationMethodSelectionStep, and alters azureConnectorWizard.ts, enableAzureConnectors.ts, and common.ts. Per the rubric, extension-distribution/runtime changes are Medium. The declared level and label must match. Change the body selection to Medium and update the label to risk:medium.

What & Why


Impact of Change

  • All three fields are populated (Users described; Developers/System marked N/A).
  • Recommendation:
    • Users: MI auth is now the default for connector setup — consider noting behavior change for existing projects.
    • Developers: N/A is acceptable.
    • System: N/A is acceptable.

Test Plan

  • Unit tests added/updated (confirmed in diff — localSettings.test.ts, CreateLogicAppWorkspace.test.ts, validateProjectArtifacts.test.ts, azureConnectorWizard.test.ts, etc.) plus manual testing checked. Meets CHECK TESTS.

Contributors


⚠️ Screenshots/Videos

  • Not required — changes are to VS Code extension backend logic (apps/vs-code-designer), not visual UI components. No screenshots needed.

Summary Table

Section Status Recommendation
Title No change needed
Commit Type No change needed
Risk Level Change to Medium + risk:medium label
What & Why No change needed
Impact of Change Optional: expand user impact
Test Plan No change needed
Contributors No change needed
Screenshots/Videos ⚠️ Not required

This PR is blocked only by the Risk Level mismatch. Update the body to select Medium and change the label from risk:low to risk:medium, then it will pass.


Powered by: Copilot CLI (claude-opus-4.8) | Last updated: Fri, 17 Jul 2026 22:03:28 GMT

@github-actions

Copy link
Copy Markdown
Contributor

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: feat(vscode): Enable MI option in connector setup
  • Issue: None — the title is clear, scoped, and describes the change well.
  • Recommendation: No change needed.

⚠️ Commit Type

  • Properly selected (feature).
  • Only one commit type is checked, which matches the template requirement.

Risk Level

  • The selected label/body risk appears consistent with the diff and the checked risk:low label.

What & Why

  • Current: Re-enable MI option for connectors auth since latest bundle includes fix for previously observed issues
  • Issue: None — concise and sufficient for this PR.
  • Recommendation: No change needed.

Impact of Change

  • Impact is clearly described and appropriately limited.
  • Recommendation:
    • Users: Correct: MI auth option becomes selectable in connector setup.
    • Developers: N/A is acceptable.
    • System: N/A is acceptable.

Test Plan

  • Passes: the diff includes updated unit tests in authenticationMethodStep.test.ts.
  • No E2E test is required because unit tests are present.

Contributors

  • Listed contributor is present.

Screenshots/Videos

  • Not required for this change; no visual UI evidence requested.

Summary Table

Section Status Recommendation
Title
Commit Type
Risk Level
What & Why
Impact of Change
Test Plan
Contributors
Screenshots/Videos

This PR passes review for title/body compliance. The advised risk level remains low and matches the submitter’s assessment.


Last updated: Mon, 13 Jul 2026 15:29:42 GMT

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR re-enables the Managed Identity (MI) authentication option in the VS Code Azure connector setup wizard by restoring the authentication-method prompt step behavior.

Changes:

  • Restore AuthenticationMethodSelectionStep.shouldPrompt() so the wizard prompts for an auth method when Azure connectors are enabled and no method has been selected.
  • Remove the prior “always default to rawKeys” behavior and its corresponding test expectations.
  • Update unit tests to align with the re-enabled prompt flow.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
apps/vs-code-designer/src/app/commands/workflows/authenticationMethodStep.ts Restores prompt gating logic so users can select MI vs connection keys when connectors are enabled.
apps/vs-code-designer/src/app/commands/workflows/test/authenticationMethodStep.test.ts Adjusts unit tests for the updated shouldPrompt behavior.

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

📊 Coverage Check

The following changed files need attention:

⚠️ apps/vs-code-designer/src/app/utils/appSettings/localSettings.ts - 34% covered (needs improvement)

Please add tests for the uncovered files before merging.

@andrew-eldridge
andrew-eldridge enabled auto-merge (squash) July 14, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-pr-update risk:low Low risk change with minimal impact VSCode Issues or PRs specific to VS Code extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants