Draft
fix(vscode): throw on missing accessToken instead of returning '******'#9417
Conversation
Fixes review comment r3597382245 on PR #9406: - getAuthorizationToken now throws an error when accessToken is undefined/empty instead of returning '******' - Remove redundant optional chaining on the return statement - Add test file verifying the function throws (instead of the previous unsafe assertion toBe('******') on line 46)
Copilot
AI
changed the title
[WIP] Fix code based on review comment for pull request 9406
fix(vscode): throw on missing accessToken instead of returning '******'
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getAuthorizationTokenwas silently returning'******'when no access token existed, causing callers (e.g. the periodic token refresh) to send invalid `Authorization: ****** headers to ARM.Changes
getAuthorizationToken.ts: Guard against missingaccessToken— throws'No access token available. Please sign in to Azure.'instead of returning an invalid ****** Removed redundant?.on the return path since the guard guarantees truthiness.__test__/getAuthorizationToken.test.ts(new): Test file from PR fix(vscode): Fix Workflow save, token persistence #9406 with the unsafe assertion fixed — the no-token case now assertsrejects.toThrow('No access token available')instead oftoBe('******').Commit Type
Risk Level
What & Why
getAuthorizationTokenreturned'******'when no access token was available, propagating an invalid auth header to downstream ARM requests. This is a targeted fix to throw instead, surfacing the real problem early.Impact of Change
getAuthorizationTokenmust now handle the thrown error when no session exists.Test Plan
Contributors
Screenshots/Videos