test(shared): Add workflow expression coverage

[ccastrotrejo]

Commit Type

• feature - New functionality
• fix - Bug fix
• refactor - Code restructuring without behavior change
• perf - Performance improvement
• docs - Documentation update
• test - Test-related changes
• chore - Maintenance/tooling

Risk Level

• Low - Minor changes, limited scope
• Medium - Moderate changes, some user impact
• High - Major changes, significant user/system impact

What & Why

The workflow expression scanner, parser, and builder are foundational Logic Apps business logic but previously lacked direct unit coverage. This PR adds 67 focused tests for their established behavior without modifying production code.

The tests cover tokenization and expression limits, literals and nested functions, dereferences and safe navigation, alias-path handling, template interpolation, serialization, round trips, and error paths.

Impact of Change

• Users: No user-facing behavior changes.
• Developers: Adds regression protection and executable documentation for workflow expression handling.
• System: Test-only change with no runtime, API, dependency, or architecture impact.

Test Plan

• Unit tests added/updated
• E2E tests added/updated
• Manual testing completed
• Tested in: Biome checks passed; targeted expression tests passed (67/67) with 100% statements/functions/lines and 98.75% branch coverage; full @microsoft/logic-apps-shared suite passed (953 tests, no type errors); GitHub Actions run 29615327286 completed successfully, including vscode-e2e-summary.

Contributors

@ccastrotrejo

Screenshots/Videos

N/A

[github-actions]

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

✅ PR Title

• Current: test(shared): Add workflow expression coverage
• Issue: None — uses the valid test(scope): prefix and clearly describes the change.
• Recommendation: No change needed.

---

✅ Commit Type

• Exactly one type selected: test - Test-related changes.
• This correctly matches the diff, which adds only *.spec.ts files under libs/logic-apps-shared/.../expression/__test__/.

---

✅ Risk Level

• Low selected in the body and the risk:low label is present — both consistent.
• This matches the advised estimate: the diff is test-only (three new spec files, no production code touched), so there is no runtime, API, dependency, or user-facing impact. Low is correct.

---

✅ What & Why

• Current: Explains that the scanner, parser, and builder lacked direct unit coverage and that 67 focused tests were added without modifying production code.
• Issue: None — clear and specific.
• Recommendation: No change needed.

---

✅ Impact of Change

• All three audiences addressed (Users: none; Developers: regression protection/executable docs; System: test-only, no runtime impact).
• Recommendation:
  • Users: No user-facing behavior changes (accurate).
  • Developers: Adds regression protection for expression handling (accurate).
  • System: Test-only, no runtime/API/dependency impact (accurate).

---

✅ Test Plan

• Unit tests added/updated is checked and confirmed in the diff (builder/parser/scanner specs). Verification details (67/67 passing, full shared suite green) are provided. Passes CHECK TESTS.

---

✅ Contributors

• Credits @ccastrotrejo. No action needed.

---

✅ Screenshots/Videos

• Not required — the diff only adds test files and touches no visual UI components. N/A is appropriate.

---

Summary Table

Section	Status	Recommendation
Title	✅	No change needed
Commit Type	✅	No change needed
Risk Level	✅	Low is correct (test-only)
What & Why	✅	No change needed
Impact of Change	✅	No change needed
Test Plan	✅	Unit tests confirmed in diff
Contributors	✅	No change needed
Screenshots/Videos	✅	Not applicable

---

All checks pass — this test-only PR is compliant and cleared to merge.

---

Powered by: Copilot CLI (claude-opus-4.8) | Last updated: Fri, 17 Jul 2026 22:12:05 GMT

[Copilot]

Pull request overview

Adds focused Vitest unit coverage for the workflow expression scanner/parser/builder in logic-apps-shared, capturing existing behavior and edge cases without changing production code.

Changes:

• Added scanner tests covering tokenization, punctuation, identifiers, numeric and string literal handling, whitespace, and error cases.
• Added parser tests covering literals, nested functions, dereferences (including safe navigation), alias-path splitting, and template interpolation parsing.
• Added builder tests covering expression/template serialization, escaping rules, dereference emission, and parse→build canonical round-trips.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
libs/logic-apps-shared/src/parsers/lib/expression/test/scanner.spec.ts	New unit coverage for ExpressionScanner tokenization and scanner error behaviors.
libs/logic-apps-shared/src/parsers/lib/expression/test/parser.spec.ts	New unit coverage for ExpressionParser AST output across literals, functions, dereferences, alias paths, and templates.
libs/logic-apps-shared/src/parsers/lib/expression/test/builder.spec.ts	New unit coverage for ExpressionBuilder serialization and canonical round-trips.