[App Config] Update CLI to use Audience and update to 1.8.0#33393
Open
mrm9084 wants to merge 9 commits into
Open
[App Config] Update CLI to use Audience and update to 1.8.0#33393mrm9084 wants to merge 9 commits into
mrm9084 wants to merge 9 commits into
Conversation
mrm9084
requested review from
DanielMicrosoft,
Pan-Qi,
ReaNAiveD,
VeryEarly,
bebound,
jiasli,
jsntcy,
necusjz and
yonzhan
as code owners
May 18, 2026 23:33
❌AzureCLI-FullTest
|
|
Hi @mrm9084, |
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
Bot
requested review from
avanigupta,
yanzhudd and
zhoxing-ms
May 18, 2026 23:33
microsoft-github-policy-service
Bot
added
App Configuration
Auto-Assign
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prepares az appconfig for azure-appconfiguration 1.8.0 by changing AAD login auth to provide an audience when the active cloud does not define one.
Changes:
- Bumps
azure-appconfigurationdependency in setup metadata to~=1.8.0. - Falls back to using the App Configuration endpoint as the token audience.
- Updates an AAD auth live test assertion for the new audience behavior.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/azure-cli/setup.py |
Updates the App Configuration SDK dependency version. |
src/azure-cli/azure/cli/command_modules/appconfig/_utils.py |
Adds endpoint fallback for App Configuration token audience selection. |
src/azure-cli/azure/cli/command_modules/appconfig/tests/latest/test_appconfig_aad_auth.py |
Updates the expected credential audience in the live AAD auth scenario. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jimmyca15
approved these changes
May 19, 2026
Member
|
The PR title should probably also mention the sdk version update |
Member
Author
|
@VeryEarly can you review this? |
Pan-Qi
previously approved these changes
Jun 5, 2026
Member
Author
|
@VeryEarly can you please review this PR? |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
necusjz
previously approved these changes
Jun 30, 2026
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 33393 in repo Azure/azure-cli |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
VeryEarly
reviewed
Jul 15, 2026
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az appconfig
Description
When updating to the
1.8.0version of the python sdk it will result in us breaking in all non hardcoded regions, such as Bleu.This PR adds a check that will attempt to get the audience from the endpoint if an audience isn't provided.
This PR also updates us to 1.8.0.
This PR also updates to use entra ID for tests.
Testing Guide
Get a config store in Bleu, you'll see that you can connect without providing the audience manually like you can in 1.7.2.
History Notes
Make is so the 1.8.0 release of the python sdk will not break all of our existing customers in non-public/ff/mc clouds.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.