fix: strip colon from parsed NewReplicaSet name#543
Open
ejaifeobuks wants to merge 3 commits into
Open
Conversation
Include the trailing colon in the 'newreplicaset:' keyword so substring() removes "NewReplicaSet:" entirely. Previously the colon was left behind, causing getNewReplicaSet to return ":" instead of the actual ReplicaSet name. Also update the getNewReplicaSet unit test to use realistic colon-delimited `kubectl describe` output, which the previous mock omitted. Resolves Azure#318
bosesuneha
reviewed
Jul 15, 2026
| const describeReturn = { | ||
| exitCode: 0, | ||
| stdout: newReplicaSetName + name + ' ' + 'extra', | ||
| stdout: newReplicaSetName + ' ' + name + ' ' + 'extra', |
Member
There was a problem hiding this comment.
can you use something like "NewReplicaSet: my-app-6d4cf56db6 (1/1 replicas created)" which resembles real output for the test?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor adjustment to the way new replica sets are identified in both the
Kubectlclass and its associated test. The change ensures that the string'newreplicaset:'(with a colon) is used as the identifier instead of'newreplicaset'(without a colon), improving the accuracy of matching lines related to new replica sets.'newreplicaset'to'newreplicaset:'in both theKubectlclass and its test to ensure correct parsing of replica set lines. [1] [2]Include the trailing colon in the 'newreplicaset:' keyword so substring() removes "NewReplicaSet:" entirely. Previously the colon was left behind, causing getNewReplicaSet to return ":" instead of the actual ReplicaSet name.Also update the getNewReplicaSet unit test to use realistic colon-delimited
kubectl describeoutput, which the previous mock omitted.Resolves #318