Skip to content

Migrate @azure-tools/typespec-go from autorest.go into this repo#4628

Open
tadelesh wants to merge 56 commits into
mainfrom
go-migration
Open

Migrate @azure-tools/typespec-go from autorest.go into this repo#4628
tadelesh wants to merge 56 commits into
mainfrom
go-migration

Conversation

@tadelesh

@tadelesh tadelesh commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Migrates @azure-tools/typespec-go from Azure/autorest.go into this monorepo. See Azure/autorest.go#1982 for full background and plan.

What's in this PR

Source code (Phase 3 of the migration plan)

  • New packages/typespec-go/ containing the emitter and its three previously-private workspace dependencies inlined:
    • codegen.go → src/codegen/
    • codemodel.go → src/codemodel/
    • naming.go → src/naming/
  • Static assets: README.md, LICENSE, CHANGELOG.md, vitest.config.ts, tsconfig.json (mirrors typespec-python).
  • .chronus change entry.

Tests

The emitter is tested with three tiers, in order of preference (documented in docs/development.md):

  1. Emitter unit tests (scenarios) — the default. Markdown snapshot tests under test/unittest/scenarios/*.md: each .md compiles a small TypeSpec in memory and snapshots the generated Go, with no Go toolchain or mock server. ~29 focused scenarios cover naming, models/serialization, client & options shapes, polymorphism, client customizations (@@alternateType / @@clientName), containing-module, sample generation (example JSON input → *_example_test.go), and the former Regressions code-gen cases.
    • scenario-runner.ts — in-memory compile + snapshot harness (SCENARIOS_UPDATE=true regenerates expected blocks; ARM specs auto-routed to an ARM tester).
    • gen-scenario-suites.mjs — generates one vitest suite per .md; scenario-suites.guard.test.ts fails if they drift.
  2. External service specs — all Azure RM / data-plane service specs (17 modules) are sourced from Azure/azure-rest-api-specs at a pinned commit via a sparse, blobless, shallow clone:
    • .scripts/azure-rest-api-specs.json — pinned commit + sparse paths
    • .scripts/sync-azure-rest-api-specs.js — idempotent sync (skipped when cache marker matches)
    • .scripts/tspconfig.yaml — stub config that suppresses upstream tspconfig bleed (the per-language @azure-tools/typespec-go options that target azure-sdk-for-go)
  3. Local spec tests — kept only where the behavior can only be verified by executing generated Go at runtime. Just two remain:
    • gogenerate (test/tsp/GoGenerate → test/local/gogenerate) — the post-generation go generate hook.
    • fakeserver (test/tsp/FakeServer → test/local/fakeserver) — fake-server runtime behavior (context cancellation, dispatch races, path/query decoding); a minimal 2-operation spec.

Removed local specs (migrated into scenarios): ClientOption, Internal.Pager, ModelsOnlyWithBaseTypes, NoOptionalBody, PageableLROs, Random.Management, RawJson, and the Test.Management ARM provider. The old Regressions grab-bag was split into scenarios plus the slimmed fakeserver runtime test. The local ExactName test was dropped (duplicated by an azure-http-specs scenario).

Build / regenerate

  • .scripts/tspcompile.js — Always invoked with --config=.scripts/tspconfig.yaml so upstream tspconfigs don't bleed.
  • .scripts/semaphore.js — 8-way parallel compile primitive.
  • .scripts/spector.js — reused start/stop wrapper around npx tsp-spector.

CI

  • .github/workflows/ci-go.yml — jobs: build, test (Go matrix 1.26.1/1.25.8 with regenerate + lint:go + spector-backed test:go:e2e), unit (vitest), docs (regen-docs).
  • .github/actions/setup-go/action.yml — composite wrapping actions/setup-go@v5.
  • eng/config/labels.ts — adds emitter:go area label + path mapping.
  • eng/pipelines/jobs/build-for-publish.yml — adds Go regen + e2e + upload-spector-coverage.yml template call (GeneratorName=@azure-tools/typespec-go) after the Python block.
  • tsconfig.ws.json includes the new package.
  • Root mise.toml pins go = "1.26.1" for local development; in CI Go is installed via actions/setup-go (GH Actions) and GoTool@0 (ADO release pipeline).
  • .gitignore ignores generated zz_*.go / go.mod / go.sum / LICENSE.txt / testdata under packages/typespec-go/test/.

Skipped per discussion

  • No nightly pipeline — all TypeSpec deps live in this repo now.
  • test/local/ stays in this repo — not relocated to azure-sdk-for-go.

Validation (local)

  • pnpm build ✅
  • pnpm test (vitest unit) ✅ 47/47 (29 scenario suites + guard + emitter tests)
  • pnpm regenerate ✅ all tsp compiles
  • pnpm format:check ✅ clean for all packages/typespec-go/** files
  • pnpm lint:go ✅ 0 issues (golangci-lint v2.11.4 + shadow, every generated module)
  • pnpm test:go:e2e ✅ spector start → hand-written test modules (azblob / azkeys / gogenerate / fakeserver) PASS → spector stop

Follow-ups (out of scope; tracked in autorest.go#1982)

  • Migrate remaining swagger-based data-plane SDKs to the latest autorest.go (Phase 1, in flight).
  • Stop maintaining codegen.go / codemodel.go / naming.go in autorest.go once Phase 4 lands.
  • Announce deprecation of autorest.go (after Phase 4).

github-advanced-security[bot]
github-advanced-security AI found potential problems Jun 15, 2026
View reviewed changes
Comment thread packages/typespec-go/src/codegen/fake/servers.ts Dismissed
@azure-sdk

azure-sdk commented Jun 15, 2026 •
edited by azure-sdk-automation Bot
Loading

Copy link
Copy Markdown
Collaborator

All changed packages have been documented.

  • ✅ @azure-tools/typespec-go
Show changes

@azure-tools/typespec-go - internal ✏️

Move @azure-tools/typespec-go from Azure/autorest.go into Azure/typespec-azure. The previously-private workspace packages @azure-tools/codegen.go, @azure-tools/codemodel.go, and @azure-tools/naming.go are now inlined into src/codegen, src/codemodel, and src/naming respectively. No behavior changes for emitter consumers.

@github-actions

github-actions Bot commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚡ Benchmark Results

⚠️ 5 metric(s) regressed above the +5% threshold:

Metric Baseline Current Change
 ↳ linter/@azure-tools/typespec-azure-core/no-header-explode 🔴 26.7ms 🔴 28.2ms +5.4% 🔴
 ↳ linter/@azure-tools/typespec-azure-core/no-query-explode 🔴 27.8ms 🔴 29.2ms +5.0% 🔴
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-agent-base-type-child-resources 🔴 21.1ms 🔴 22.5ms +6.7% 🔴
 ↳ linter/@azure-tools/typespec-azure-resource-manager/lro-location-header 🟡 19.7ms 🔴 21.1ms +7.2% 🔴
 ↳ linter/@azure-tools/typespec-azure-resource-manager/no-response-body 🔴 29.8ms 🔴 31.7ms +6.2% 🔴
Full details – comparing 980c530 vs baseline rolling-baseline-1a09577-3e6a2b2 (rolling baseline (20 main runs))
Metric Baseline Current Change
total 🔴 1.01s 🔴 1.05s +3.6%
loader 🟡 305.6ms 🟡 316.9ms +3.7%
resolver 🟢 40.1ms 🟢 40.4ms +0.6%
checker 🟡 364.2ms 🟡 378.5ms +3.9%
validation 🟢 84.6ms 🟢 86.7ms +2.5%
 ↳ validation/@azure-tools/typespec-azure-core 🟡 12.6ms 🟡 13.1ms +4.1%
 ↳ validation/@typespec/http 🟡 15.5ms 🟡 16.3ms +4.8%
 ↳ validation/@typespec/rest 🟢 1.6ms 🟢 1.7ms +3.3%
 ↳ validation/@typespec/versioning 🔴 50.9ms 🔴 51.7ms +1.5%
 ↳ validation/compiler 🟢 3.8ms 🟢 3.9ms +1.4%
linter 🟡 215.2ms 🟡 223.6ms +3.9%
 ↳ linter/@azure-tools/typespec-azure-core/auth-required 🟢 0.1ms 🟢 0.1ms +4.3%
 ↳ linter/@azure-tools/typespec-azure-core/bad-record-type 🟢 0.6ms 🟢 0.6ms -0.4%
 ↳ linter/@azure-tools/typespec-azure-core/byos 🟢 8.4ms 🟢 8.6ms +3.4%
 ↳ linter/@azure-tools/typespec-azure-core/casing-style 🟢 1.5ms 🟢 1.5ms +2.6%
 ↳ linter/@azure-tools/typespec-azure-core/composition-over-inheritance 🟢 0.2ms 🟢 0.2ms +2.0%
 ↳ linter/@azure-tools/typespec-azure-core/documentation-required 🟢 2.0ms 🟢 2.0ms +0.8%
 ↳ linter/@azure-tools/typespec-azure-core/friendly-name 🟢 1.4ms 🟢 1.4ms +2.1%
 ↳ linter/@azure-tools/typespec-azure-core/key-visibility-required 🟢 0.4ms 🟢 0.4ms +3.3%
 ↳ linter/@azure-tools/typespec-azure-core/known-encoding 🟢 0.5ms 🟢 0.5ms +2.0%
 ↳ linter/@azure-tools/typespec-azure-core/long-running-polling-operation-required 🟢 0.8ms 🟢 0.8ms +0.9%
 ↳ linter/@azure-tools/typespec-azure-core/no-case-mismatch 🟢 0.7ms 🟢 0.7ms +1.1%
 ↳ linter/@azure-tools/typespec-azure-core/no-closed-literal-union 🟢 1.0ms 🟢 1.0ms -0.1%
 ↳ linter/@azure-tools/typespec-azure-core/no-enum 🟢 0.2ms 🟢 0.2ms +1.4%
 ↳ linter/@azure-tools/typespec-azure-core/no-error-status-codes 🟢 0.3ms 🟢 0.3ms +2.7%
 ↳ linter/@azure-tools/typespec-azure-core/no-explicit-routes-resource-ops 🟢 0.2ms 🟢 0.2ms +3.1%
 ↳ linter/@azure-tools/typespec-azure-core/no-format 🟢 0.8ms 🟢 0.8ms -0.0%
 ↳ linter/@azure-tools/typespec-azure-core/no-generic-numeric 🟢 0.8ms 🟢 0.9ms +1.9%
 ↳ linter/@azure-tools/typespec-azure-core/no-header-explode 🔴 26.7ms 🔴 28.2ms +5.4% 🔴
 ↳ linter/@azure-tools/typespec-azure-core/no-legacy-usage 🟢 2.1ms 🟢 2.1ms +3.0%
 ↳ linter/@azure-tools/typespec-azure-core/no-multiple-discriminator 🟢 0.2ms 🟢 0.2ms +5.6%
 ↳ linter/@azure-tools/typespec-azure-core/no-nullable 🟢 0.4ms 🟢 0.4ms +4.2%
 ↳ linter/@azure-tools/typespec-azure-core/no-offsetdatetime 🟢 2.0ms 🟢 2.0ms +3.2%
 ↳ linter/@azure-tools/typespec-azure-core/no-openapi 🟢 2.3ms 🟢 2.3ms -0.3%
 ↳ linter/@azure-tools/typespec-azure-core/no-private-usage 🟢 3.2ms 🟢 3.3ms +2.3%
 ↳ linter/@azure-tools/typespec-azure-core/no-query-explode 🔴 27.8ms 🔴 29.2ms +5.0% 🔴
 ↳ linter/@azure-tools/typespec-azure-core/no-response-body 🔴 33.3ms 🔴 34.9ms +4.8%
 ↳ linter/@azure-tools/typespec-azure-core/no-rest-library-interfaces 🟢 0.1ms 🟢 0.1ms +7.3%
 ↳ linter/@azure-tools/typespec-azure-core/no-route-parameter-name-mismatch 🟢 7.7ms 🟢 8.1ms +6.1%
 ↳ linter/@azure-tools/typespec-azure-core/no-rpc-path-params 🟢 0.4ms 🟢 0.4ms +2.3%
 ↳ linter/@azure-tools/typespec-azure-core/no-string-discriminator 🟢 0.1ms 🟢 0.1ms +4.0%
 ↳ linter/@azure-tools/typespec-azure-core/no-unknown 🟢 0.3ms 🟢 0.4ms +1.7%
 ↳ linter/@azure-tools/typespec-azure-core/no-unnamed-union 🟢 0.8ms 🟢 0.8ms +0.6%
 ↳ linter/@azure-tools/typespec-azure-core/operation-missing-api-version 🟢 0.4ms 🟢 0.4ms -0.0%
 ↳ linter/@azure-tools/typespec-azure-core/request-body-problem 🟢 0.5ms 🟢 0.5ms +0.4%
 ↳ linter/@azure-tools/typespec-azure-core/require-versioned 🟢 0.1ms 🟢 0.1ms +2.8%
 ↳ linter/@azure-tools/typespec-azure-core/response-schema-problem 🔴 32.7ms 🔴 34.2ms +4.5%
 ↳ linter/@azure-tools/typespec-azure-core/rpc-operation-request-body 🟢 0.7ms 🟢 0.7ms +3.5%
 ↳ linter/@azure-tools/typespec-azure-core/spread-discriminated-model 🟢 0.5ms 🟢 0.5ms +1.4%
 ↳ linter/@azure-tools/typespec-azure-core/use-standard-names 🟢 7.6ms 🟢 8.0ms +4.9%
 ↳ linter/@azure-tools/typespec-azure-core/use-standard-operations 🟢 0.3ms 🟢 0.3ms +0.1%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-agent-base-type-child-resources 🔴 21.1ms 🔴 22.5ms +6.7% 🔴
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-agent-base-type-lifecycle-operations 🟢 0.3ms 🟢 0.3ms +0.0%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-common-types-version 🟡 12.1ms 🟡 12.7ms +5.0%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-custom-resource-no-key 🟢 0.2ms 🟢 0.2ms +2.7%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-custom-resource-usage-discourage 🟢 0.1ms 🟢 0.1ms +1.3%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-delete-operation-response-codes 🟢 5.0ms 🟢 4.5ms -10.3%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-no-path-casing-conflicts 🟡 17.0ms 🟡 17.2ms +1.1%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-no-record 🟢 0.6ms 🟢 0.7ms +5.5%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-post-operation-response-codes 🟢 1.4ms 🟢 1.3ms -4.4%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-put-operation-response-codes 🟢 0.2ms 🟢 0.2ms -1.4%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-action-no-segment 🟢 0.4ms 🟢 0.5ms +1.0%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-duplicate-property 🟢 0.4ms 🟢 0.4ms +3.6%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-interface-requires-decorator 🟢 0.1ms 🟢 0.1ms -1.3%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-invalid-action-verb 🟢 0.2ms 🟢 0.2ms +0.6%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-invalid-envelope-property 🟢 0.3ms 🟢 0.3ms +4.7%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-invalid-version-format 🟢 0.2ms 🟢 0.2ms +0.0%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-key-invalid-chars 🟢 0.5ms 🟢 0.5ms +6.0%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-name-pattern 🟢 0.1ms 🟢 0.1ms -2.1%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-operation 🟢 0.5ms 🟢 0.6ms +1.6%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-operation-response 🟢 9.0ms 🟢 9.3ms +3.2%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-patch 🟢 0.8ms 🟢 0.8ms -1.1%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-path-segment-invalid-chars 🟢 0.4ms 🟢 0.4ms +4.8%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-provisioning-state 🟢 0.4ms 🟢 0.4ms +3.1%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/beyond-nesting-levels 🟢 0.2ms 🟢 0.2ms +1.0%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/empty-updateable-properties 🟢 0.4ms 🟢 0.4ms +0.2%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/improper-subscription-list-operation 🟢 0.1ms 🟢 0.1ms +10.2%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/lro-location-header 🟡 19.7ms 🔴 21.1ms +7.2% 🔴
 ↳ linter/@azure-tools/typespec-azure-resource-manager/missing-operations-endpoint 🟢 0.1ms 🟢 0.1ms +4.1%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/missing-x-ms-identifiers 🟢 1.0ms 🟢 1.0ms +0.6%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/no-empty-model 🟢 0.3ms 🟢 0.3ms +3.9%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/no-override-props 🟢 0.3ms 🟢 0.3ms +0.8%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/no-reserved-resource-property 🟢 0.2ms 🟢 0.2ms -1.1%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/no-resource-delete-operation 🟢 0.5ms 🟢 0.5ms +2.0%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/no-response-body 🔴 29.8ms 🔴 31.7ms +6.2% 🔴
 ↳ linter/@azure-tools/typespec-azure-resource-manager/patch-envelope 🟢 0.4ms 🟢 0.4ms +2.5%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/resource-name 🟢 0.4ms 🟢 0.4ms +0.5%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/secret-prop 🟢 5.4ms 🟢 5.2ms -3.1%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/unsupported-type 🟢 0.7ms 🟢 0.7ms -2.5%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/version-progression 🟢 0.3ms 🟢 0.3ms -2.8%
 ↳ linter/@azure-tools/typespec-client-generator-core/property-name-conflict 🟢 2.3ms 🟢 2.3ms +0.9%
 ↳ linter/@azure-tools/typespec-client-generator-core/require-client-suffix 🟢 1.7ms 🟢 1.7ms +2.5%
emit 🔴 6.04s 🔴 6.27s +3.7%
 ↳ emit/@Azure-Tools 🟢 0.0ms 🟢 0.0ms +0.0%
 ↳ emit/@azure-tools/typespec-autorest 🟢 125.4ms 🟢 128.3ms +2.3%
 ↳ emit/@azure-tools/typespec-python 🔴 2.25s 🔴 2.34s +4.1%
 ↳ emit/@typespec 🟢 0.0ms 🟢 0.0ms +0.0%
 ↳ emit/@typespec/http-client-js 🔴 571.0ms 🔴 586.4ms +2.7%
 ↳ emit/@typespec/openapi3 🟢 107.9ms 🟢 112.0ms +3.7%
 ↳ emit/@typespec/openapi3/compute 🟢 93.8ms 🟢 97.2ms +3.7%
 ↳ emit/@typespec/openapi3/write 🟢 13.8ms 🟢 14.4ms +4.3%

Averaged across 3 specs (azure-arm-resource-manager, azure-core-dataplane, azure-full).
Threshold: changes > ±5% are highlighted.
🟢 Fast · 🟡 Moderate (stages >200ms, rules >10ms) · 🔴 Slow (stages >400ms, rules >20ms)

@pkg-pr-new

pkg-pr-new Bot commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@azure-tools/typespec-go@4628

commit: 9a20f7b

@azure-sdk

azure-sdk commented Jun 15, 2026 •
edited by azure-sdk-automation Bot
Loading

Copy link
Copy Markdown
Collaborator

You can try these changes here

🛝 Playground 🌐 Website

tadelesh and others added 5 commits June 15, 2026 15:45
fix lint
318d074
Merge remote-tracking branch 'origin/main' into go-migration
9766f31
fix(ci-go): quote command substitutions to satisfy shellcheck SC2086
f9acb87 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
fix(typespec-go): fix spelling typos and configure cspell
3c03b63 
- Fix 13 spelling typos carried over from upstream source (acceptible,
  credendial, defef, deferenced, depracated, Disciminator, encounted,
  enveloipe, furture, hepler, Iterface, specifiy, uhandled).
- Rename formatValue's defef parameter to deref (callers pass positionally).
- Rename trackDisciminator function to trackDiscriminator.
- Add cspell ignorePaths for packages/typespec-go/{test,temp,.scripts}/**.
- Add legitimate Go SDK identifiers (azfake, azidentity, GOPATH, Errorf,
  Fatalf, polymorphics, Retriable, Unmarshaller, etc.) and Go stdlib
  package names (cmplx, fcgi, flate, gofmt, pkix, etc.) to dictionary.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
fix(cspell): lowercase Go emitter words for case-insensitive matching
ff41435 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
chore: sync labels for emitter:go
22d28c5 
Ran pnpm sync-labels to regenerate triage policy files and CONTRIBUTING.md
labels reference with the new emitter:go area label.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
tadelesh and others added 4 commits June 15, 2026 16:27
fix(ci-go): use full pnpm install for unit/docs jobs
f184a20 
The filtered install (--filter @azure-tools/typespec-go...) doesn't pull in
core's workspace-root devDependencies (prettier-plugin-organize-imports),
which @typespec/xml's gen-extern-signature -> tspd -> prettier requires
at build time. Match the build/test jobs and install everything.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
fix(typespec-go): un-ignore test fixtures required by regenerate
2bec532 
- nooptionalbody/testdata/generate/transforms.go: hand-authored helper invoked by after_generate.go's //go:generate directive. Without it, the emit's post-step go generate fails, cleanGeneratedFiles wipes all zz_*.go except zz_version.go, and the orphan triggers a downstream golangci-lint 'unused const' error.

- rawjson/go.mod and go.sum: rawjson uses containing-module=rawjson/v2 and emits into subpkg/. The module root (one level up) must exist for the emit's post-step go mod tidy to find go.mod.

Also: surface emit failures in tspcompile.js by setting process.exitCode = 1. Previously a failed emit only logged 'exec error' and let the script exit 0, hiding the failure until a downstream lint job complained.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
chore: re-sync labels to align emitter order with eng/config/labels.ts
cbd0588 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
update
8913669
tadelesh and others added 2 commits June 15, 2026 17:16
chore: sync CONTRIBUTING.md banner with sync-labels script output
db99e1a 
verify-labels CI runs pnpm sync-labels --github --check which requires the banner emitted by core/eng/common/scripts/labels/definitions.ts:295 to match exactly. PR #4563 had hand-patched the banner to a different path that the script never reproduces, so any PR touching CONTRIBUTING.md or eng/config/labels.ts fails the check. Re-running pnpm sync-labels produces this content; committing verbatim.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
feat(typespec-go): auto-sync generated tests with azure-sdk-assets ba…
788114b 
…seline

After pnpm regenerate finishes, the locally regenerated test artifacts under packages/typespec-go/test/{local,http-specs,azure-http-specs}/ are automatically mirrored into a sparse checkout of Azure/azure-sdk-assets@typespec-go in packages/typespec-go/temp/baseline/. Developers can then inspect codegen deltas with a plain git -C temp/baseline status / git diff — no separate command needed.

- New .scripts/sync-baseline.js: idempotent shallow+blobless sparse clone (test/local, test/http-specs, test/azure-http-specs); mirror copies the local tree into the checkout after regen.

- tspcompile.js: kicks off the sync at startup and runs the mirror in beforeExit so it fires after every emit's async callback has drained. Skipped on regen failure (process.exitCode != 0) so partial output doesn't pollute the baseline.

- ci-go.yml: TYPESPEC_GO_SKIP_BASELINE=1 on the Regenerate step so CI doesn't need network access to azure-sdk-assets.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
timotheeguerin
timotheeguerin reviewed Jun 15, 2026
View reviewed changes
Comment thread .chronus/changes/typespec-go-move-into-typespec-azure-2026-06-11-14-30-00.md Outdated
Comment thread .github/actions/setup-go/action.yml
Comment thread packages/typespec-go/package.json Outdated
Comment thread packages/typespec-go/package.json Outdated
Comment thread .github/workflows/ci-go.yml
jhendrixMSFT
jhendrixMSFT reviewed Jun 15, 2026
View reviewed changes
Comment thread packages/typespec-go/.scripts/azure-rest-api-specs.json
@jhendrixMSFT

jhendrixMSFT commented Jun 15, 2026

Copy link
Copy Markdown
Member

Are there plans to get more granular WRT what runs in CI? At present it looks like quite a few things ran that's not germane to this emitter.

Copilot and others added 10 commits July 1, 2026 17:45
fix(typespec-go): resolve lint failures (deprecation warnings + OOM)
3759486 
The merge bumped TCGC, which now marks correspondingMethodParams and
serializedName as deprecated, producing eslint warnings that fail the
--max-warnings=0 lint gate. Add file-level no-deprecated disables to
clients.ts and types.ts, matching the existing convention in adapter.ts
(these TCGC APIs are used intentionally as documented fallbacks).

Additionally, adding the large typespec-go emitter to the type-aware lint
pass pushes eslint past the default ~4 GB Node heap, causing an OOM
(exit 134) in CI. Raise NODE_OPTIONS max-old-space-size to 8 GB for the
Lint job (runner has 16 GB) so type-aware linting stays enabled across
all packages instead of excluding typespec-go like typespec-ts/core.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@tadelesh
revert
8a84128
@tadelesh
Merge branch 'main' into go-migration
35af6d2
@tadelesh
fix merge issue
538e211
chore: regenerate label policy files via sync-labels
d9cd537 
The merge left a duplicate emitter:go entry in the generated triage
policies and CONTRIBUTING.md. Regenerate from eng/config/labels.ts to
deduplicate, fixing the ''label section is not up to date'' verify check.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
test(typespec-go): disable armcognitiveservices regen (TCGC override …
298a2f7 
…false positive)

The merged TCGC bump validates @OverRide parameter mismatches inside the
$override decorator, which runs regardless of the emitting language. The
upstream CognitiveServices.Management spec has a JavaScript-scoped
@OverRide (checkSkuAvailability) that drops @path on the realized
''location'' path parameter, so compiling for Go now fails with
override-parameters-mismatch even though the override targets javascript.

Upstream main carries the same spec and we already have the latest TCGC
override fixes, so this cannot be resolved from the go-migration branch
without editing upstream specs or changing cross-language TCGC validation.
Disable the spec's Go test generation with a comment; re-enable once TCGC
scopes the validation to the current emitter or the spec adds a suppress.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Merge remote-tracking branch 'origin/main' into go-migration
12e847f 
# Conflicts:
#	cspell.yaml
#	eng/pipelines/jobs/build-for-publish.yml
#	pnpm-lock.yaml
#	tsconfig.ws.json
remove all arm tests
86dd12d
ci: migrate sdk-regenerate pipeline from autorest.go
6300d67 
Bring over the ARM SDK regeneration pipeline that produces regenerate PRs
against Azure/azure-sdk-for-go, replacing the real ARM service specs that
were removed from typespec-go's local test set. Supports both released and
dev (locally built) emitter modes, matching the original.

Adaptations for typespec-azure:
- checkout self as typespec-azure with submodules: recursive (core)
- build via root pnpm install + turbo build of @azure-tools/typespec-go...
  (emitter plus its in-repo workspace deps) instead of a single-package build
- add NodeVersion to globals.yml
- dev mode: read the emitter's generation-time dependency versions from the
  packed .tgz (where pnpm rewrites workspace: specifiers to concrete ranges)
  instead of the source package.json, so emitter-package.json gets valid
  published versions rather than workspace: specifiers

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Revert "ci: migrate sdk-regenerate pipeline from autorest.go"
f63d29b 
This reverts commit 6300d67.
@tadelesh tadelesh mentioned this pull request Jul 7, 2026
Open
tadelesh and others added 12 commits July 8, 2026 13:38
Merge remote-tracking branch 'origin/main' into go-migration
0197331
test(typespec-go): migrate emitter integration tests to markdown snap…
1617ded 
…shot unit tests

Replace most hand-written local spec integration tests with fast, in-memory
markdown-driven snapshot unit tests under test/unittest/scenarios. Each scenario
compiles TypeSpec in-process and snapshots the generated Go source, run via vitest.

- Add the scenario harness (scenario-runner.ts), per-file suite generator
  (gen-scenario-suites.mjs), and a drift guard (scenario-suites.guard.test.ts).
- Migrate ClientOption, Internal.Pager, ModelsOnlyWithBaseTypes, NoOptionalBody,
  PageableLROs, Random.Management, RawJson and Test.Management (ARM) specs into
  focused scenarios, including sample-generation and example-input support.
- Migrate the Regressions code-gen cases into scenarios; slim the remaining
  integration test to fake-server runtime behavior and rename it to fakeserver.
- Keep gogenerate as a post-generation go-generate integration test.
- Document the testing strategy (scenarios first; local specs only for runtime
  Go behavior) in docs/development.md.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
format
9859d5b
@tadelesh
Merge branch 'main' into go-migration
502576f
build(typespec-go): add pnpm test:update to regenerate scenario sna…
75040b4 
…pshots

Adds a `test:update` script that runs vitest with SCENARIOS_UPDATE=true to
rewrite the expected output blocks in test/unittest/scenarios/*.md in place.
Uses a small .scripts/test-update.js wrapper (matching the existing script
wrappers) to set the env var cross-platform without a new dependency. Update
the development doc to reference the command.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
build(typespec-go): prune unused azure-rest-api-specs sparse paths
76116b0 
tspcompile.js now only sources two service specs from azure-rest-api-specs
(keyvault Keys → azkeys, storage BlobStorage → azblob); the other 15 RM/data-plane
spec paths are no longer referenced. Drop them from the sparse-checkout list so the
sync fetches only what the tests need.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
docs(typespec-go): reflow development guide and fix lint scope
81fd368 
Collapse wrapped prose paragraphs to single lines and correct the lint:go
description to note it covers test/local, test/http-specs and test/azure-http-specs
(not just test/local).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
docs(typespec-go): clarify what pnpm regenerate covers under test/
81c5409 
The old intro claimed everything under test/ is generated from specs. Describe the
actual mix (in-memory unit tests, local spec tests, external Spector specs) and note
that regenerate only writes the Go fixtures under test/local, test/http-specs and
test/azure-http-specs, while test/unittest is updated via pnpm test:update.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
docs(typespec-go): reorganize development guide around generated code…
3de5919 
… vs tests

The old Step 3 (Regenerate) and Step 4 (Test) were both loosely "about tests" and
awkwardly ordered, while the closely-related Step 5 (Review the generated-code diff)
sat after them. Restructure so the steps follow the actual workflow:

- Step 3 "Regenerate and validate the generated code" now groups everything about
  the generated artifacts: regenerate, review the baseline diff (merged from the old
  Step 5), run the Go tests, lint the generated Go, and debug.
- Step 4 "Add or update tests" is now purely about authoring tests: choosing the
  right tier and writing an emitter unit-test scenario.
- Renumber the remaining steps and fix all cross-references and the TOC.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
docs(typespec-go): unify testing into a single "Test your changes" step
a995edc 
Regenerating fixtures, running the Go tests and linting are all part of the same
testing story as the unit-test scenarios (they exercise tiers 2 and 3 of the test
taxonomy), so splitting them across two top-level steps was artificial. Merge them
into one "Step 3: Test your changes" ordered from cheapest to heaviest: choose the
tier, write an in-memory scenario, then (for the generated-Go tiers) regenerate,
review the diff, run the Go tests, and lint. Renumber docs/PR to Steps 4/5 and fix
the TOC and cross-references.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
fix(typespec-go): use %s + err.Error() in JSON unmarshaller errors
5bfcb65 
Ports Azure/autorest.go#2022 into the migrated emitter: emit
`fmt.Errorf("unmarshalling type %T: %s", recv, err.Error())` instead of the
`%v` + err form in the three JSON-unmarshaller code paths. This makes the intent
to propagate the error message explicit and avoids tripping errorlint in the
generated code.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
release(typespec-go): sync 0.14.3 version and changelog from autorest.go
2e39187 
Bump the package version to 0.14.3 and add the 0.14.3 changelog section to match
the upstream Azure/autorest.go release (adapting Access.internal polymorphic
returns; JSON unmarshalling errors now use %s + err.Error()).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@tadelesh tadelesh closed this Jul 10, 2026
@tadelesh tadelesh reopened this Jul 10, 2026
Merge origin/main into go-migration
9a20f7b 
Resolve conflict in eng/pipelines/jobs/build-for-publish.yml: main (#4824)
decoupled emitter e2e + spector-coverage from the publish critical path by moving
those steps into eng/pipelines/jobs/spector-coverage.yml. Take main's version of
build-for-publish.yml and add the Go e2e steps as a new `spector_go` job in
spector-coverage.yml, matching the Python/Java/TS jobs (turbo-cache restore +
GoTool + regenerate + test:go:e2e + upload-spector-coverage).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timotheeguerin timotheeguerin timotheeguerin left review comments
@jhendrixMSFT jhendrixMSFT jhendrixMSFT left review comments
@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner
@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner
+1 more reviewer
@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

eng meta:website TypeSpec.io updates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tadelesh @azure-sdk @jhendrixMSFT @timotheeguerin @github-advanced-security