test(admin): verify events are emitted correctly on revoke - #619
Open
Fayyo wants to merge 1 commit into
Open
Conversation
|
@Fayyo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #481
Adds two new tests for revoke event correctness:
test_revoke_role_emits_event_with_correct_role_for_each_role— analogous to the existingtest_grant_role_emits_event_with_correct_role_for_each_role, asserting that revoking SuperAdmin, Pauser, and Minter each emit arole_rvkevent with the correct role, admin, and address.test_revoke_role_event_records_contract_admin— analogous to the existingtest_grant_role_event_records_the_granting_caller, verifying that when a non-admin SuperAdmin performs the revoke, the event records the contract admin from storage (matching the current_revoke_rolebehavior viaget_admin).All 67 tests pass.