Daniel back buttom#1735
Conversation
BrianRamsay
left a comment
BrianRamsay
left a comment
There was a problem hiding this comment.
The buttons are no longer centered on the page at the bottom of the form.
Resolved Back Button |
MImran2002
left a comment
MImran2002
left a comment
There was a problem hiding this comment.
branch:
still not centered
development:
| <div class="w-100 m-auto"> | ||
| <!--Submission buttons--> | ||
| {% if not event %} | ||
| <a href="javascript:window.history.back();" class="btn btn-secondary" btn-sm m-2> Back</a> |
There was a problem hiding this comment.
I feel this violated the separation of concern that css should not be in HTML, javascript should not be in HTML. Instead because this back button we clearly knows where it will go we can use this href="/something" for example as we know the route.
|
|
||
| {% if volunteer != g.current_user %} | ||
| <div class="text-center my-3"> | ||
| <a href="javascript:window.history.back();" class="btn btn-secondary">Back</a> |
There was a problem hiding this comment.
same here too this violated the separation of concern
Previously the back button only appeared during event creation. Added back button for existing events (expired and not-yet-completed) that navigates to the event view page, as requested in PR review.
…wareDevTeam/celts into daniel_back_buttom
|
Tell me when you guys are done and this issue as brian has commented means you also need to get his approval |
|
@nahom70 and @DanielRukwasha reach out to Brian so that you can get his approval and be able to merge this issue. if we don't proactively do this it becomes an outstanding PR. |
4 participants
Back Button Implementation
Fixes issue #1596
Changes
Testing
-we checked through the website using inspect, and manupilate tabs.