Skip to content

Bonner req#1738

Open
DanielRukwasha wants to merge 15 commits into
developmentfrom
bonner_req
Open

Bonner req#1738
DanielRukwasha wants to merge 15 commits into
developmentfrom
bonner_req

Conversation

@DanielRukwasha

Copy link
Copy Markdown
Contributor

Issue Description

Fixes issue #1600

  • Redesign confusing non-functional "X" icons to improve clarity, consistency, and alignment. The current icons suggest delete/close actions but have no behavior, creating misleading user expectations. we put Incomplete and complete

Changes

-Replaced the bi-x icon with a gray "Incomplete" badge

  • Replaced the bi-check icon with a green "Completed" badge
  • Used a flex layout (justify-content-between) so badges align consistently on the right
  • Added border-bottom separators between rows for easier scanning
  • Optional requirements now display an (Optional) label in muted text

Testing

  • Added RequirementMatch test data in test_data.py linking Bonner requirements to existing events so both badge states can
    be verified
  • To test: visit /profile/neillz or /profile/khatts as ramsayb2 and open the Bonner Scholar accordion → Requirement
    Progress
  • Expected: neillz and khatts show Completed for Bonner Orientation, all others show Incomplete
  • we altered the requirement condition, to see incomplete or complete

DanielRukwasha and others added 12 commits June 18, 2026 11:01
…gress

- Remove bi-x icon (looked like delete/close, did nothing)
- Replace with 'Not Started' (gray) and 'Completed' (green) Bootstrap badges
- Use flex layout (justify-content-between) for consistent right-alignment
- Add border-bottom separator between rows for scannability
- Label optional requirements with a muted (Optional) note
Links Bonner Orientation (req 1) to event 1 and All Bonner Meeting (req 2)
to event 2. neillz/khatts/ayisie show Completed for req 1; neillz/partont
show Completed for req 2. Remaining requirements show Incomplete.
@github-actions

Copy link
Copy Markdown

View Code Coverage

@MImran2002

Copy link
Copy Markdown
Contributor

This issue is still in working, there is an exisitng issue that is waiting for approval. That I worked on before : #1437

@DanielRukwasha

Copy link
Copy Markdown
Contributor Author

This PR and #1437 (bonnerCheckmarkProfile) both modify the same block in app/templates/main/userProfile.html (the Bonner Requirement Progress list) - #1437 adds frequency-aware (x/y) counts and a details popover, while this PR redesigns the same list items as Completed/Incomplete badges.

To avoid a conflicting merge, I'd propose: merge #1437 first (it carries the core counting logic + tests), then I'll rebase this branch on top of development and reconcile the two - applying the badge/flex styling on top of the frequency-count content from #1437, and updating test_data.py to cover both.

@MImran2002 does that sequencing work for you?

@MImran2002

Copy link
Copy Markdown
Contributor

Hi Daniel, after talking to Brian, he will be review the bonner checkmark profile first so I would want this PR to be a stand still for now on because after talking to our client the closest come to is the bonner checkmark profile PR after that is merge we will have a new issue that is going to expand on that. So I would wait for any changes until that one is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants