Skip to content

Contributors list#592

Open
BhushanSah wants to merge 7 commits into
developmentfrom
contributors_list
Open

Contributors list#592
BhushanSah wants to merge 7 commits into
developmentfrom
contributors_list

Conversation

@BhushanSah

Copy link
Copy Markdown
Contributor

fixes #591
Fixed the layout design for the footer.

@BhushanSah BhushanSah requested a review from MImran2002 June 23, 2026 14:01
@BhushanSah BhushanSah self-assigned this Jun 23, 2026
Comment thread app/static/css/base.css Outdated

@MImran2002 MImran2002 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure the back button within the page is also centered.

@MImran2002 MImran2002 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image image 1. footer should be at the bottom 2. needs to have no white space on two of its sides.

@MImran2002 MImran2002 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Celts back button in the contributor which is center:

Image

LSF back button in the contributor which is not center:

Image

@nahom70 nahom70 added epic A project that will require multiple sub-tasks to complete and removed epic A project that will require multiple sub-tasks to complete labels Jul 1, 2026
@BhushanSah

Copy link
Copy Markdown
Contributor Author

Celts back button in the contributor which is center:

Image LSF back button in the contributor which is not center: Image

Done

@BhushanSah BhushanSah closed this Jul 1, 2026
@BhushanSah

Copy link
Copy Markdown
Contributor Author

Celts back button in the contributor which is center:
Image
LSF back button in the contributor which is not center:
Image

Done

@BhushanSah BhushanSah reopened this Jul 1, 2026
@BhushanSah

Copy link
Copy Markdown
Contributor Author

Fixed the footer issue too

@MImran2002

Copy link
Copy Markdown
Contributor

Your branch:
image

Development:
image

@MImran2002 MImran2002 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went inside and try to make some change this is my suggestion: the lsf as it is is working. you don't have to worry about but the concerns for the footer and not being center try looking at the elements on whether it is not a footer issue but something nested or so. My suggestion is to use inspect, there is the way for you to edit style live do that. I feel like the changes that are made are more than necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fixed the layout for footer.

3 participants