Fix dummy elements push in GSA10#359
Open
johannaisak wants to merge 3 commits into
Open
Conversation
Update ToGsaString for Bars for GSA10 to use correct GSA string so that dummy elements are pushed correctly
Once the dummy tag was added, it no longer worked to push tie or bar elements with end releases defined (in GSA end releases for these elements are handled by the element type). Updated to only include end releases for Beam elements.
Contributor
Author
|
@BHoMBot check installer |
|
@johannaisak to confirm, the following actions are now queued:
|
Line break change to recreate installer
Contributor
Author
|
@BHoMBot check installer |
|
@johannaisak to confirm, the following actions are now queued:
There are 5 requests in the queue ahead of you. |
RubenKoopman
approved these changes
Jul 24, 2026
RubenKoopman
left a comment
RubenKoopman
left a comment
There was a problem hiding this comment.
I have tested this code for creating dummy elements in GSA10 and updating releases for bars. It works as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
Issues addressed by this PR
Closes #358
Updated GSA string for push to GSA10 to correctly use dummy flag.
As part of this had to update so that releases are only defined for beam elements, as the push wouldn't work otherwise. In GSA end releases for elements other than beams are dealt with by the member type itself so this change doesn't cause any issues.
Test files
https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/GSA_Toolkit/%23359-DummyElementsInGSA10?csf=1&web=1&e=fV0V18
Changelog
Additional comments