Skip to content

Add Support for Joint Velocities and Accelerations - #351

Open
GCRA101 wants to merge 7 commits into
developfrom
SAP2000_Toolkit-#327-AddSupportForJointVelocitiesAndAccelerations
Open

Add Support for Joint Velocities and Accelerations#351
GCRA101 wants to merge 7 commits into
developfrom
SAP2000_Toolkit-#327-AddSupportForJointVelocitiesAndAccelerations

Conversation

@GCRA101

@GCRA101 GCRA101 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Issues addressed by this PR

Fixes #326 #327

GH Script - Success - After Pull Request SAP2000 Velocity Outputs - Success SAP2000 Acceleration Outputs - Success

SAP2000 Toolkit now can be used to extract joint velocity and acceleration outputs from SAP2000.

Test files

Grasshopper File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/SAP2000_Toolkit/%23351-AddSupportForJointsVelocityAndAcceleration/Test%20Script.gh?csf=1&web=1&e=8QGANd
SAP2000 File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/SAP2000_Toolkit/%23351-AddSupportForJointsVelocityAndAcceleration/Test%20SAP2000%20Model.sdb?csf=1&web=1&e=uh5bax

Changelog

  • Added ReadNodeVelocity Method to retrieve Abs Joint Velocities from SAP2000
    • Added ReadNodeAcceleration Method to retrieve Abs Joint Accelerations from SAP2000

@GCRA101 GCRA101 self-assigned this Jul 21, 2026
@GCRA101 GCRA101 added the type:feature New capability or enhancement label Jul 21, 2026

@peterjamesnugent peterjamesnugent left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes on how you get and verify the ids in the requests - I've provided some links to Lusas where we do similar calls.

Comment thread SAP2000_Adapter/CRUD/Read/Results/BarResults.cs Outdated
Comment thread SAP2000_Adapter/CRUD/Read/Results/NodeResults.cs Outdated
Comment thread SAP2000_Adapter/CRUD/Read/Results/Result.cs
Comment thread SAP2000_Adapter/CRUD/Read/Results/Result.cs
@GCRA101
GCRA101 requested a review from peterjamesnugent July 30, 2026 10:46
@GCRA101

GCRA101 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

@BHoMBot check required

@bhombot-ci

bhombot-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown

@GCRA101 to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 395 requests in the queue ahead of you.

@GCRA101

GCRA101 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

@BHoMBot check required

@bhombot-ci

bhombot-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown

@GCRA101 to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 203 requests in the queue ahead of you.

@bhombot-ci

bhombot-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci

bhombot-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci

bhombot-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci

bhombot-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown

The check serialisation has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci

bhombot-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci

bhombot-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@GCRA101

GCRA101 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

@BHoMBot check installer

@bhombot-ci

bhombot-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown

@GCRA101 to confirm, the following actions are now queued:

  • check installer

There are 243 requests in the queue ahead of you.

@peterjamesnugent peterjamesnugent left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the code changes, all comments addressed and the generic id method is very neat.

Will merge once someone has tested the functionality with SAP2000.

@bhombot-ci

bhombot-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:feature New capability or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Feature to Retrieve Joint Accelerations

2 participants