Skip to content

Revit tagging tool #179 refactor settings#344

Open
vietle-bh wants to merge 6 commits into
developfrom
Revit_Tagging_Tool-#179-RefactorSettings
Open

Revit tagging tool #179 refactor settings#344
vietle-bh wants to merge 6 commits into
developfrom
Revit_Tagging_Tool-#179-RefactorSettings

Conversation

@vietle-bh

Copy link
Copy Markdown
Contributor

Issues addressed by this PR

Helps close https://github.com/BuroHappoldEngineering/Revit_Tagging_Tool/issues/179

This pull request introduces several upgrade methods to the v93 upgrader, focusing on improving the migration of tagging settings objects to newer versions. The main enhancements involve flattening nested settings structures and handling property renames or removals to align with updated object models.

New upgrade methods for tagging settings:

Helper method for flattening:

  • Introduced a private FlattenBaseSettings method to move properties from the nested BaseSettings dictionary to the top level, simplifying the upgrade logic for all tagging settings. ([BHoMUpgrades/CustomUpgrades/v93.csR35-R150])

Test files

Please see https://github.com/BuroHappoldEngineering/Revit_Tagging_Tool/pull/180

Changelog

Additional comments

@vietle-bh vietle-bh self-assigned this Jul 23, 2026
@vietle-bh vietle-bh added the type:compliance Non-conforming to code guidelines label Jul 23, 2026
@bhombot-ci

bhombot-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown

@vietle-bh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @vietle-bh on Revit_Tagging_Tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:compliance Non-conforming to code guidelines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant