Revit tagging tool #179 refactor settings#344
Open
vietle-bh wants to merge 6 commits into
Open
Conversation
|
@vietle-bh just to let you know, I have provided a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Helps close https://github.com/BuroHappoldEngineering/Revit_Tagging_Tool/issues/179
This pull request introduces several upgrade methods to the
v93upgrader, focusing on improving the migration of tagging settings objects to newer versions. The main enhancements involve flattening nested settings structures and handling property renames or removals to align with updated object models.New upgrade methods for tagging settings:
UpgradeMEPGlobalTagSettingsto flatten theUseExclusionZonesproperty from the nestedBhomSettingsdictionary to the top level and remove it from the nested dictionary. ([BHoMUpgrades/CustomUpgrades/v93.csR35-R150])UpgradePointTagSettingsto flatten base settings, renameRiserLeaderAngletoOrthogonalLeaderAngle, and removeTagObscuredDisciplineElements. ([BHoMUpgrades/CustomUpgrades/v93.csR35-R150])UpgradeCurveTagSettingsto flatten base settings and remove bothKeepTagPlacementPointOnHostandTagObscuredDisciplineElements. ([BHoMUpgrades/CustomUpgrades/v93.csR35-R150])UpgradeAreaTagSettingsto flatten base settings and remove bothRiserLeaderAngleandTagObscuredDisciplineElements. ([BHoMUpgrades/CustomUpgrades/v93.csR35-R150])Helper method for flattening:
FlattenBaseSettingsmethod to move properties from the nestedBaseSettingsdictionary to the top level, simplifying the upgrade logic for all tagging settings. ([BHoMUpgrades/CustomUpgrades/v93.csR35-R150])Test files
Please see https://github.com/BuroHappoldEngineering/Revit_Tagging_Tool/pull/180
Changelog
Additional comments