test: cover navigation browser contracts - #86
Merged
Conversation
6 tasks
Owner
Author
|
Acceptance review found two P1 blockers:
Implementation has been returned for these focused fixes. |
30 tasks
Banegasn
force-pushed
the
codex/issue-12-cross-browser
branch
from
July 29, 2026 16:43
09f7614 to
f42918c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Partially addresses #12.
This is the first focused browser-contract batch. It deliberately covers only the public navigation family:
It adds reusable Lit browser-contract helpers; deterministic layout, event, slot, accessibility, reconnect-cleanup coverage; and an Istanbul browser-coverage ratchet. The two packages run in Chromium, Firefox, and WebKit and are ratcheted at 100% statements, branches, functions, and lines. CI prints the summaries without retaining coverage artifacts.
Follow-up plan
Continue #12 in focused public component-family batches (for example, button/chip/badge or input controls), adding a package to the ratchet only after all of that package production source is exercised in the three-browser matrix. Do not treat the remaining packages that still use the explicit temporary no-test status as covered.
Validation
pnpm test is otherwise clean for this batch but currently fails on the pre-existing WebKit-only m3-menu test synchronously hides and escapes the menu when a real Tab key moves focus: WebKit leaves document.activeElement on body instead of the expected next button. This PR does not modify the already-merged menu contract.