r-zip: update to 3.0.0, drop obsolete libr-zip.patch#367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #366. cc @pekkarr (maintainer)
Updates
r-zipto 3.0.0 and removeslibr-zip.patch, which no longer applies to the rewritten 3.0.0 source (now bundles a Mbed TLS subset for WinZip AES crypto + new source files). That stale patch was the cause of theprepare()failure that kept the package pinned at 2.3.3.Why dropping the patch is safe
mz_→r_mz_rename worked around symbol collisions (upstream issue Refresh depends for all r pkgs #98). zip 3.0.0'sMakevarsbuilds withPKG_CFLAGS = $(C_VISIBILITY)(-fvisibility=hidden), which hides the bundled-miniz symbols at link time — the modern fix for that collision.libr-zip.so.r-zipis the only package in the repo that referencedlibr-zip; no other PKGBUILD links/usr/lib/libr-zip.so. The package now ships the standardusr/lib/R/library/zip/libs/zip.solike every other R package.Other changes
r-clistays inmakedepends(CRANLinkingTo: cli, added in r-zip: add r-cli makedepend for CRAN 3.0.0 #362) and is also added tooptdepends(it's in 3.0.0Suggests).optdependsrefreshed to 3.0.0Suggests: addedr-callr,r-curl,r-webfakes; droppedr-covr(no longer suggested).checkdepends/repo_makedepends: addedr-curlandr-webfakes— the newtest-http.Rrange-request tests need them (the suite'sskip_if_not_installedonly skips under_R_CHECK_FORCE_SUGGESTS_=false, so they run and require the deps present).Verification
Built locally with
makepkg:zip.so.usr/lib/R/library/zip/libs/zip.so+usr/share/licenses/r-zip/LICENSE, nolibr-zip.so.