ci: don't run live-prod tests in CI; run pytest locally only#96
Merged
Conversation
Tests hit live production endpoints and depend on prod data availability (DEX 404s, premium 'no data found'). Drop the pytest step from the workflow so CI runs only black + flake8 across the matrix. Tests stay runnable locally via: DATAMAXI_API_KEY=... python -m pytest tests/ Closes #95
This was referenced Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI was failing only on the Python 3.14 job — not a 3.14 bug. The
Test with pyteststep was gated toif: matrix.python-version == '3.14', so 3.14 was the only version that actually ran the suite. Those tests hit live production endpoints and depend on prod data availability, so they fail nondeterministically in CI:/api/v1/premiumreturns an empty page for some filter combos, which the SDK turns intoValueError("no data found").This PR removes the pytest step from
.github/workflows/python-package.yml. CI now runs onlyblack+flake8across the 3.10–3.14 matrix and never touches the production API. The test suite is unchanged and stays runnable locally:Tests
Known failures
DATAMAXI_API_KEYrepo secret is now unused by this workflow; left in place intentionally.Closes #95