Dead code removal, exception hygiene, tab reformat

[dylanuys]

Continuation of the code-quality burndown (#407, #409). Independent pieces, one commit each — the reformat commit is whitespace-only and safe to skip in review.

Dead code (580f30a)

Deletes three functions whose features live on in their replacements, all with zero callers:

• generate_prompts_from_image / generate_scene_from_image → replaced by the batch pipeline (generate_scenes_batch + compose_prompts_from_scenes)
• save_images_to_disk → replaced by generator_service._write_media
• is_duplicate → replaced by compute_media_hash + check_duplicate_in_db

Also removes the never-called get_service_info methods (registry uses get_info()) and replaces the __import__("sqlite3").Row inline-import hack with a normal top-level import in the three db stores.

local_service signposting (58d0beb)

Kept as a reference implementation, now with an explicit do-not-enable banner: local generation produces no C2PA provenance, so its output fails validator verification.

Exception hygiene (e69d4af)

All six remaining bare except: clauses fixed — temp-file cleanups narrowed to except OSError, the rest to except Exception with the error logged. The silent _save_profiles_to_cache swallows now log at debug. Also fixes a SyntaxWarning from an unescaped regex in a docstring. E722 added to the CI lint gate.

Tab reformat (f5436f1 + 404da99)

content_manager.py was the repo's last tab-indented file (2,362 tabs). Converted to 4-space; AST verified identical modulo docstring whitespace. W191 added to the CI gate, and the reformat SHA is recorded in .git-blame-ignore-revs (GitHub blame picks this up automatically; locally run git config blame.ignoreRevsFile .git-blame-ignore-revs once).

Dependency security burndown (8576233)

Attacks the 120 Dependabot alerts (1 critical, 47 high). Fixes the critical and ~22 of the 27 unique highs.

Removed — verified never imported anywhere in the repo:

• onnx (inference happens inside gasbench via its own onnxruntime-gpu) — kills all 6 onnx alerts
• python-multipart (FastAPI only needs it for form parsing; we have no form endpoints) — kills all 6
• asyncpg (no postgres anywhere anymore)
• Cargo-culted pins of other packages' transitives: sympy, coloredlogs, flatbuffers, humanfriendly, scikit-learn, nest-asyncio — still installed via their real requirers where needed
• black + pre-commit moved from runtime deps to the dev group

Bumped direct pins with CVEs:

• pillow 10.4.0 → 12.2.0 — OOB writes parsing malformed images; validators parse miner-submitted media, so this is the security bump that matters most
• diffusers 0.36.0 → 0.38.0 (trust_remote_code bypass), pyarrow 19.0.1 → 23.0.1, python-dotenv 1.0.1 → 1.2.2
• httpcore 1.0.7 → 1.0.9 — unblocks h11 0.16.0, the one critical (malformed chunked-encoding)

Lockfile-only (transitive) upgrades: GitPython 3.1.50, urllib3 2.7.0, cryptography 49.0.0, msgpack 1.2.1, protobuf 5.29.6, ecdsa 0.19.2, and ~150 others via uv lock --upgrade.

New guard: [tool.uv] constraint-dependencies = ["torchaudio==2.7.1"] — torchaudio wheels declare no torch dependency, so without this the resolver floats it to versions ABI-incompatible with pinned torch 2.7.1 (it had already drifted to 2.11.0 on the first lock upgrade).

Deliberately not fixed:

• aiohttp / starlette / setuptools alerts — hard-blocked by bittensor 9.9.0's own pins (aiohttp~=3.9, fastapi~=0.110.1, setuptools~=70); requires a bittensor SDK bump
• torch / transformers — major-version jumps, not worth the GPU-stack risk for medium-severity alerts
• ecdsa Minerva timing attack — no upstream patch exists

⚠️ Testnet note: the pillow 10→12 and diffusers 0.36→0.38 bumps touch live media-parsing and generation paths that CI doesn't exercise — worth a testnet soak before this reaches mainnet validators.

No behavior changes outside the dependency bumps. CI is green at every commit, not just HEAD.

🤖 Generated with Claude Code