Sync DEFAULT_DISPUTE_TIMEOUT_SECS with expiry action default and admin-set timeouts - #341
Open
micmusjnr20 wants to merge 2 commits into
Open
Sync DEFAULT_DISPUTE_TIMEOUT_SECS with expiry action default and admin-set timeouts#341micmusjnr20 wants to merge 2 commits into
micmusjnr20 wants to merge 2 commits into
Conversation
…n-set timeouts - Update dispute.rs module docs to document 7-day default timeout - Add test_default_dispute_timeout_used_when_not_explicitly_set - Add get_dispute_timeout/get_dispute_expiry_action to README metadata table
Sync DEFAULT_DISPUTE_TIMEOUT_SECS with expiry action default and admin-set timeouts
Contributor
|
@micmusjnr20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DEFAULT_DISPUTE_TIMEOUT_SECS(7 days) andDisputeExpiryAction::RefundOwnerwere declared as separate defaults instorage.rsbut the relationship between them was undocumented, untested for the default path, and missing from the public API docs.Changes
DEFAULT_DISPUTE_TIMEOUT_SECSimport andtest_default_dispute_timeout_used_when_not_explicitly_settest verifying the default timeout (7 days), default action (RefundOwner), andget_dispute_timeout()return value when no explicit value is set.get_dispute_timeout()andget_dispute_expiry_action()to the Metadata API table with their defaults.Files touched
app/contract/contracts/Folder/src/dispute.rsapp/contract/contracts/Folder/src/test.rsapp/contract/README.mdVerification
Rust toolchain not available in this environment; review the changes manually or run
cargo testlocally.Closes #334